GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] Revert "gh-115432: Add critical section variant that handles a NULL object (GH-115433)" (GH-118861) by miss-islington · Pull Request #118872 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This reverts commit ad4f909.

The API ended up not being used.
(cherry picked from commit 46c8081)

Co-authored-by: Sam Gross [email protected]

  • Issue: Add variant of Py_BEGIN_CRITICAL_SECTION that accepts a NULL argument #115432

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury @miss-islington
Revert "pythongh-115432: Add critical section variant that handles a …
8f03d20 
…NULL object (pythonGH-115433)" (pythonGH-118861)

This reverts commit ad4f909.

The API ended up not being used.
(cherry picked from commit 46c8081)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Add variant of Py_BEGIN_CRITICAL_SECTION that accepts a NULL argument #115432
Closed
@bedevere-app bedevere-app Bot added the skip news label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)" #118861
Merged
@colesbury
colesbury merged commit b62cb52 into python:3.13 May 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 9, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@miss-islington
miss-islington deleted the backport-46c8081-3.13 branch January 2, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.