GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)" by colesbury · Pull Request #118861 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This reverts commit ad4f909.

This internal API ended up not being used.

  • Issue: Add variant of Py_BEGIN_CRITICAL_SECTION that accepts a NULL argument #115432

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
Revert "pythongh-115432: Add critical section variant that handles a …
49a359e 
…NULL object (python#115433)"

This reverts commit ad4f909.

The API ended up not being used.
@colesbury colesbury added skip news topic-free-threading labels May 9, 2024
@colesbury
colesbury requested a review from DinoV May 9, 2024 18:09
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Add variant of Py_BEGIN_CRITICAL_SECTION that accepts a NULL argument #115432
Closed
@colesbury
colesbury marked this pull request as ready for review May 9, 2024 18:10
@bedevere-app bedevere-app Bot added the awaiting core review label May 9, 2024
@colesbury
colesbury requested a review from Yhg1s May 9, 2024 18:12
@colesbury

colesbury commented May 9, 2024

Copy link
Copy Markdown
Contributor Author

@Yhg1s - this isn't really a bug fix, but it's definitely not a feature. Would it be appropriate to backport this revert to 3.13?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury force-pushed the gh-115432-revert branch from 9f8175b to 49a359e Compare May 9, 2024 18:26
DinoV
DinoV approved these changes May 9, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 9, 2024
@Yhg1s

Yhg1s commented May 9, 2024

Copy link
Copy Markdown
Member

Yeah, backporting it to 3.13 is fine until we get to rc1.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury colesbury added the needs backport to 3.13 only security fixes label May 9, 2024
@colesbury
colesbury merged commit 46c8081 into python:main May 9, 2024
@colesbury
colesbury deleted the gh-115432-revert branch May 9, 2024 22:33
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@colesbury @miss-islington
Revert "pythongh-115432: Add critical section variant that handles a …
8f03d20 
…NULL object (pythonGH-115433)" (pythonGH-118861)

This reverts commit ad4f909.

The API ended up not being used.
(cherry picked from commit 46c8081)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118872 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
colesbury added a commit that referenced this pull request May 9, 2024
@miss-islington @colesbury
[3.13] Revert "gh-115432: Add critical section variant that handles a…
b62cb52 
… NULL object (GH-115433)" (GH-118861) (#118872)

This reverts commit ad4f909.

The API ended up not being used.
(cherry picked from commit 46c8081)

Co-authored-by: Sam Gross <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@colesbury @SonicField
Revert "pythongh-115432: Add critical section variant that handles a …
9c4ae02 
…NULL object (python#115433)" (python#118861)

This reverts commit ad4f909.

The API ended up not being used.
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @Yhg1s @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.