GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119185: Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager` by Sachaa-Thanasius · Pull Request #118881 · python/cpython

Conversation

@Sachaa-Thanasius

@Sachaa-Thanasius Sachaa-Thanasius commented May 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The function name has an underscore. Without this, calling help can cause an exception.

Should be reproducible by calling help() in the repl on Windows. I personally found it by calling it on sysconfig.get_config_var.

Doesn’t seem worthy of a news entry.

  • Issue: ipython breaks on Python-3.13.0b1 when a 'tempfilepager' is not defined  #119185

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
stonebig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Sachaa-Thanasius
Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager
403b3e5 
The name with no underscore doesn't exist.
@ghost

ghost commented May 10, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label May 10, 2024
@Sachaa-Thanasius
Merge branch 'main' into patch-1
cde6745
@bedevere-app

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Sachaa-Thanasius
Merge branch 'main' into patch-1
5d18889
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 Eclips4 mentioned this pull request May 19, 2024
ipython breaks on Python-3.13.0b1 when a 'tempfilepager' is not defined #119185
Closed
@Eclips4 Eclips4 changed the title Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager May 19, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label May 19, 2024
@Eclips4
Eclips4 requested a review from pablogsal May 19, 2024 20:51
Eclips4
Eclips4 approved these changes May 19, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 19, 2024
@Eclips4 Eclips4 added the skip news label May 19, 2024
@Sachaa-Thanasius
Merge branch 'main' into patch-1
4262812
@JelleZijlstra
JelleZijlstra merged commit 05e1dce into python:main May 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 20, 2024
@miss-islington-app

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @Sachaa-Thanasius for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
Sachaa-Thanasius reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@Sachaa-Thanasius @miss-islington
pythongh-119185: Fix typo in _pyrepl.pager: tempfilepager should …
3f0adf5 
…be `tempfile_pager` (pythonGH-118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119211 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2024
@Sachaa-Thanasius
Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:54
@Sachaa-Thanasius
Sachaa-Thanasius restored the patch-1 branch May 20, 2024 14:55
@Sachaa-Thanasius
Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:55
JelleZijlstra pushed a commit that referenced this pull request May 20, 2024
@miss-islington @Sachaa-Thanasius
[3.13] gh-119185: Fix typo in _pyrepl.pager: tempfilepager should…
a52ed7e 
… be `tempfile_pager` (GH-118881) (#119211)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <[email protected]>
@ambv ambv added the topic-repl Related to the interactive shell label May 23, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@Eclips4 Eclips4 mentioned this pull request Jun 8, 2024
Windows Python help raises NameError because of missing underscore #120257
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Sachaa-Thanasius @estyxx
pythongh-119185: Fix typo in _pyrepl.pager: tempfilepager should …
b5f66ed 
…be `tempfile_pager` (python#118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Sachaa-Thanasius @Eclips4 @ambv @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.