GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118899: Add tests for `NotImplemented` attribute access by sobolevn · Pull Request #118902 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Nice issue number 😊
Inspired by #118897

  • Issue: NotImplemented is never tested with attribute assignment #118899

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-118899: Add tests for NotImplemented attribute access
49d3e6a
@sobolevn
sobolevn requested a review from JelleZijlstra May 10, 2024 13:36
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 10, 2024
NotImplemented is never tested with attribute assignment #118899
Closed
@sobolevn sobolevn added the skip news label May 10, 2024
JelleZijlstra
JelleZijlstra reviewed May 10, 2024
View reviewed changes
Comment thread Lib/test/test_builtin.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Also test ...
abaff2f
JelleZijlstra
JelleZijlstra reviewed May 12, 2024
View reviewed changes
Comment thread Lib/test/test_builtin.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Address review
8550f84
JelleZijlstra
JelleZijlstra approved these changes May 12, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 12, 2024
@sobolevn
sobolevn enabled auto-merge (squash) May 12, 2024 13:46
@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 12, 2024
@sobolevn

sobolevn commented May 12, 2024

Copy link
Copy Markdown
Member Author

Test changes are usually backported.
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn merged commit ec1398e into python:main May 12, 2024
@miss-islington-app

miss-islington-app Bot commented May 12, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 12, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
bccb0fa 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented May 12, 2024

Copy link
Copy Markdown

GH-118968 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
351358b 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 12, 2024
@bedevere-app

bedevere-app Bot commented May 12, 2024

Copy link
Copy Markdown

GH-118969 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 12, 2024
sobolevn added a commit that referenced this pull request May 12, 2024
@miss-islington @sobolevn
[3.12] gh-118899: Add tests for NotImplemented attribute access (GH…
76dc1bf 
…-118902) (#118969)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this pull request May 12, 2024
@miss-islington @sobolevn
[3.13] gh-118899: Add tests for NotImplemented attribute access (GH…
6e855b3 
…-118902) (#118968)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
2f6b607 
…hon#118902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.