GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118924: Remove `sqlite3.version` and `sqlite3.version_info` by hugovk · Pull Request #118925 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 10, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #118924.

Also alphabetically sort the other removals in What's New in 3.14, and use similar tense as in What's New in 3.13.

  • Issue: Remove sqlite3.version and sqlite3.version_info #118924

📚 Documentation preview 📚: https://cpython-previews--118925.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with hooray emoji erlend-aasland reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction
hugovk added 2 commits May 10, 2024 23:02
@hugovk
Sort removals by module, use same tense
d8dd072
@hugovk
Remove deprecated sqlite3.version and sqlite3.version_info
4f4ea18
@hugovk
hugovk requested review from berkerpeksag and erlend-aasland as code owners May 10, 2024 20:06
@bedevere-app bedevere-app Bot added the awaiting core review label May 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 10, 2024
Remove sqlite3.version and sqlite3.version_info #118924
Closed
erlend-aasland
erlend-aasland approved these changes May 10, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! BTW, why not remove the docs?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 10, 2024
hugovk added 2 commits May 10, 2024 23:15
@hugovk
Update docs
deef691
@hugovk
Fix Sphinx warnings
92d4249
@hugovk

hugovk commented May 10, 2024

Copy link
Copy Markdown
Member Author

Removed, how does this look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes May 10, 2024
View reviewed changes
@hugovk
hugovk enabled auto-merge (squash) May 10, 2024 20:27
@hugovk
hugovk merged commit a019347 into python:main May 10, 2024
@hugovk
hugovk deleted the rm-sqlite3-version-version_info branch May 10, 2024 20:42
@bedevere-app bedevere-app Bot removed the awaiting merge label May 10, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@hugovk @estyxx
pythongh-118924: Remove sqlite3.version and sqlite3.version_info (p…
e6eb9ac 
…ython#118925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove sqlite3.version and sqlite3.version_info

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.