GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118844: Fix `--disable-gil` & `--enable-experimental-jit` fails to build by savannahostrowski · Pull Request #118935 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented May 11, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: --disable-gil & --enable-experimental-jit fails to build on M1 Mac #118844

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@savannahostrowski
Add header
a818577
@savannahostrowski
savannahostrowski requested review from brandtbucher and gpshead as code owners May 11, 2024 03:10
@bedevere-app bedevere-app Bot added the awaiting review label May 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 11, 2024
--disable-gil & --enable-experimental-jit fails to build on M1 Mac #118844
Closed
@savannahostrowski

savannahostrowski commented May 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Also, make patchcheck fixed up a couple formatting issues in files? Not sure that the one in the trampoline file is desirable?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher
brandtbucher approved these changes May 11, 2024
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pretty cool to see these features being used together.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/perf_jit_trampoline.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 11, 2024
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.13 only security fixes labels May 11, 2024
@brandtbucher

brandtbucher commented May 11, 2024

Copy link
Copy Markdown
Member

Can you add a NEWS entry, too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski and others added 3 commits May 11, 2024 14:20
@savannahostrowski @brandtbucher
Update Python/perf_jit_trampoline.c
e111e00 
Co-authored-by: Brandt Bucher <[email protected]>
@blurb-it
📜🤖 Added by blurb_it.
8409154
@savannahostrowski
reword blurb
ae70d26
brandtbucher
brandtbucher reviewed May 11, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2024-05-11-21-44-17.gh-issue-118844.q2H_km.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski @brandtbucher
Update Misc/NEWS.d/next/Core and Builtins/2024-05-11-21-44-17.gh-issu…
4000624 
…e-118844.q2H_km.rst

Co-authored-by: Brandt Bucher <[email protected]>
@brandtbucher brandtbucher self-assigned this May 11, 2024
@brandtbucher
brandtbucher merged commit 5b941e5 into python:main May 11, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 11, 2024
@miss-islington-app

miss-islington-app Bot commented May 11, 2024

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2024
@savannahostrowski @miss-islington
pythonGH-118844: Fix build failures when combining --disable-gil with…
f3612d8 
… --enable-experimental-jit (pythonGH-118935)

(cherry picked from commit 5b941e5)

Co-authored-by: Savannah Ostrowski <[email protected]>
@bedevere-app

bedevere-app Bot commented May 11, 2024

Copy link
Copy Markdown

GH-118959 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 11, 2024
@stonebig stonebig mentioned this pull request May 12, 2024
Release 2024-03 follow-up winpython/winpython#1309
Closed
11 tasks done
@savannahostrowski savannahostrowski mentioned this pull request May 21, 2024
Add job to jit.yml to build and test with --disable-gil #119292
Closed
@brandtbucher brandtbucher added the topic-JIT label May 31, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@savannahostrowski @estyxx
pythonGH-118844: Fix build failures when combining --disable-gil with…
7652b6e 
… --enable-experimental-jit (pythonGH-118935)
@savannahostrowski
savannahostrowski deleted the disable-gil-and-jit branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.