GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-58933: Make pdb return to caller frame correctly when f_trace is not set by gaogaotiantian · Pull Request #118979 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented May 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For commands like next, return, until on a return event, if f_trace of the previous frame is not set, the command will not stop at the previous frame. A similar issue is fixed for step, we are generalizing that fix to commands other than continue.

  • Issue: trace function not set, causing some Pdb commands to fail #58933

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gaogaotiantian
Fix a bug where pdb skips the caller frame
ffcd0d7
@gaogaotiantian
gaogaotiantian requested a review from iritkatriel May 12, 2024 21:37
@bedevere-app bedevere-app Bot added the awaiting review label May 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 12, 2024
trace function not set, causing some Pdb commands to fail #58933
Closed
@blurb-it
📜🤖 Added by blurb_it.
9a5d83c
@gaogaotiantian gaogaotiantian added 3.12 only security fixes 3.13 only security fixes labels May 12, 2024
iritkatriel
iritkatriel approved these changes May 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 13, 2024
@iritkatriel
iritkatriel merged commit f526314 into python:main May 13, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 13, 2024
@gaogaotiantian

gaogaotiantian commented May 13, 2024

Copy link
Copy Markdown
Member Author

Hi @iritkatriel , this is a bug fix (a rather important one I think) and maybe it should be backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the needs backport to 3.12 only security fixes label May 13, 2024
@miss-islington-app

miss-islington-app Bot commented May 13, 2024

Copy link
Copy Markdown

Thanks @gaogaotiantian for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 13, 2024

Copy link
Copy Markdown

Sorry, @gaogaotiantian and @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f526314194f7fd15931025f8a4439c1765666e42 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned iritkatriel May 13, 2024
@gaogaotiantian

gaogaotiantian commented May 13, 2024

Copy link
Copy Markdown
Member Author

As main is 3.14 now, we should probably need to backport to 3.13 too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian

gaogaotiantian commented May 13, 2024

Copy link
Copy Markdown
Member Author

And I'll work on the cherry pick.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the needs backport to 3.13 only security fixes label May 13, 2024
@miss-islington-app

miss-islington-app Bot commented May 13, 2024

Copy link
Copy Markdown

Thanks @gaogaotiantian for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@gaogaotiantian @miss-islington
pythongh-58933: Make pdb return to caller frame correctly when f_trac…
e8a17fc 
…e is not set (pythonGH-118979)

(cherry picked from commit f526314)

Co-authored-by: Tian Gao <[email protected]>
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

GH-119007 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 13, 2024
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

GH-119008 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 13, 2024
@gaogaotiantian
gaogaotiantian deleted the pdb-trace-missing branch May 13, 2024 18:17
iritkatriel pushed a commit that referenced this pull request May 13, 2024
@miss-islington @gaogaotiantian
[3.13] gh-58933: Make pdb return to caller frame correctly when f_tra…
09d4c07 
…ce is not set (GH-118979) (#119007)

gh-58933: Make pdb return to caller frame correctly when f_trace is not set (GH-118979)
(cherry picked from commit f526314)

Co-authored-by: Tian Gao <[email protected]>
iritkatriel pushed a commit that referenced this pull request May 13, 2024
@gaogaotiantian
[3.12] gh-58933: Make pdb return to caller frame correctly when f_tra…
fcdd20e 
…ce is not set (GH-118979) (#119008)

* [3.12] gh-58933: Make pdb return to caller frame correctly when f_trace is not set (GH-118979)
(cherry picked from commit f526314)

Co-authored-by: Tian Gao <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@gaogaotiantian @estyxx
pythongh-58933: Make pdb return to caller frame correctly when f_trac…
0edb826 
…e is not set (python#118979)
@gaogaotiantian gaogaotiantian mentioned this pull request Oct 4, 2024
gh-124552 : Improve the accuracy of possible breakpoint check in bdb #124553
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iritkatriel iritkatriel

Labels

3.12 only security fixes 3.13 only security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gaogaotiantian @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.