GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118998: Handle errors correctly in `tmtotuple` in `timemodule` by sobolevn · Pull Request #118999 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I tried to keep the diff as minimal as possible.

  • Issue: Handle errors correctly in tmtotuple in timemodule #118998

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 13, 2024
@sobolevn
sobolevn requested a review from serhiy-storchaka May 13, 2024 13:40
@sobolevn
sobolevn requested review from abalkin and pganssle as code owners May 13, 2024 13:40
@bedevere-app bedevere-app Bot added the awaiting core review label May 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2024
Handle errors correctly in tmtotuple in timemodule #118998
Closed
@sobolevn
pythongh-118998: Handle errors correctly in tmtotuple in timemodule
8360ca5
@sobolevn
sobolevn force-pushed the issue-118998 branch from e312e3c to 8360ca5 Compare May 13, 2024 13:41
Eclips4
Eclips4 approved these changes May 13, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes May 13, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 13, 2024
@sobolevn
sobolevn merged commit fc75792 into python:main May 13, 2024
@miss-islington-app

miss-islington-app Bot commented May 13, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 13, 2024
@sobolevn

sobolevn commented May 13, 2024

Copy link
Copy Markdown
Member Author

Thanks for the reviews!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@sobolevn @miss-islington
pythongh-118998: Handle errors correctly in tmtotuple in `timemodul…
298a8f8 
…e` (pythonGH-118999)

(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@sobolevn @miss-islington
pythongh-118998: Handle errors correctly in tmtotuple in `timemodul…
ae5874b 
…e` (pythonGH-118999)

(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

GH-119018 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 13, 2024
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

GH-119019 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 13, 2024
sobolevn added a commit that referenced this pull request May 13, 2024
@miss-islington @sobolevn
[3.13] gh-118998: Handle errors correctly in tmtotuple in `timemodu…
c7628b0 
…le` (GH-118999) (#119018)

gh-118998: Handle errors correctly in `tmtotuple` in `timemodule` (GH-118999)
(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this pull request May 13, 2024
@miss-islington @sobolevn
[3.12] gh-118998: Handle errors correctly in tmtotuple in `timemodu…
5bf7f5c 
…le` (GH-118999) (#119019)

gh-118998: Handle errors correctly in `tmtotuple` in `timemodule` (GH-118999)
(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-118998: Handle errors correctly in tmtotuple in `timemodul…
652ac81 
…e` (python#118999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @serhiy-storchaka @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.