GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119009: Add gettext target by rffontenelle · Pull Request #119006 · python/cpython

Conversation

@rffontenelle

@rffontenelle rffontenelle commented May 13, 2024 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add gettext target to documentation's Makefile #119009

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

egeakman and m-aciek reacted with hooray emoji m-aciek reacted with rocket emoji
All reactions
  • 🎉 2 reactions
  • 🚀 1 reaction
@ghost

ghost commented May 13, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting review label May 13, 2024
@rffontenelle
docs: Add gettext target
5254761
@rffontenelle
rffontenelle force-pushed the add-gettext-target branch from d05ab47 to 5254761 Compare May 13, 2024 17:15
Seluj78
Seluj78 approved these changes May 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 13, 2024
egeakman
egeakman approved these changes May 13, 2024
View reviewed changes
@merwok merwok added the skip news label May 13, 2024
@merwok

merwok commented May 13, 2024

Copy link
Copy Markdown
Member

Could you copy details on the problem and proposed solution in a github issue?
That way, we have info in the issues, solution in the PR, and nothing locked in discuss.

For CPython we like to have the problem discussed in an issue, and discusson on the PR can be focussed on the implementation itself. For this ticket there probably won’t be any debate on the issue, but I wanted to clarify this part of the workflow for future contributions!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rffontenelle rffontenelle changed the title docs: Add gettext target gh-119009: Add gettext target May 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2024
Add gettext target to documentation's Makefile #119009
Closed
@rffontenelle

rffontenelle commented May 13, 2024

Copy link
Copy Markdown
Contributor Author

Could you copy details on the problem and proposed solution in a github issue?

Sure, issue opened.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented May 14, 2024

Copy link
Copy Markdown
Member

Please could you add a help entry (see line 30) so it shows up in:

❯ make -C Doc help
Please use `make <target>' where <target> is one of
  clean      to remove build files
  venv       to create a venv with necessary tools
  html       to make standalone HTML files
  htmlview   to open the index page built by the html target in your browser
  htmllive   to rebuild and reload HTML files in your browser
  htmlhelp   to make HTML files and a HTML help project
  latex      to make LaTeX files, you can set PAPER=a4 or PAPER=letter
  text       to make plain text files
  texinfo    to make Texinfo file
  epub       to make EPUB files
  changes    to make an overview over all changed/added/deprecated items
  linkcheck  to check all external links for integrity
  coverage   to check documentation coverage for library and C API
  doctest    to run doctests in the documentation
  pydoc-topics  to regenerate the pydoc topics file
  dist       to create a "dist" directory with archived docs for download
  check      to run a check for frequent markup errors
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented May 14, 2024

Copy link
Copy Markdown
Member

I get an error running this, what am I missing?

❯ make -C Doc gettext
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
/Users/hugo/github/python/cpython/main/Doc/build/NEWS is already up to date
PATH=./venv/bin:$PATH sphinx-build -b gettext -d build/doctrees -j auto   -W . build/gettext
Running Sphinx v7.3.7
loading pickled environment... done

Sphinx error:
This environment is incompatible with the selected builder, please choose another doctree directory.
make: *** [build] Error 2

That's from the repo root. I get the same thing with cd Doc; make gettext.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 14, 2024
@rffontenelle

rffontenelle commented May 14, 2024

Copy link
Copy Markdown
Contributor Author

Oh, I've seen it before. I believe to be something related to the doctree being in the same directory, but I didn't dig for the reason.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rffontenelle added 2 commits May 14, 2024 11:50
@rffontenelle
docs: Add gettext target to make help
db0ec47
@rffontenelle
docs: Use specific doctrees directory for gettext
ecdbbf7
@rffontenelle

rffontenelle commented May 14, 2024

Copy link
Copy Markdown
Contributor Author

I pushed a workaround: set another doctree directory for gettext.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes May 14, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 14, 2024
@hugovk
hugovk merged commit fb0cf7d into python:main May 15, 2024
@miss-islington-app

miss-islington-app Bot commented May 15, 2024

Copy link
Copy Markdown

Thanks @rffontenelle for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label May 15, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2024
@rffontenelle @miss-islington
pythongh-119009: Add gettext target (pythonGH-119006)
4ca3455
(cherry picked from commit fb0cf7d)

Co-authored-by: Rafael Fontenelle <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2024
@rffontenelle @miss-islington
pythongh-119009: Add gettext target (pythonGH-119006)
5de9138
(cherry picked from commit fb0cf7d)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app

bedevere-app Bot commented May 15, 2024

Copy link
Copy Markdown

GH-119074 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 15, 2024
@bedevere-app

bedevere-app Bot commented May 15, 2024

Copy link
Copy Markdown

GH-119075 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 15, 2024
hugovk pushed a commit that referenced this pull request May 15, 2024
@miss-islington @rffontenelle
[3.12] gh-119009: Add gettext target (GH-119006) (#119075)
ed395f5
Co-authored-by: Rafael Fontenelle <[email protected]>
hugovk pushed a commit that referenced this pull request May 15, 2024
@miss-islington @rffontenelle
[3.13] gh-119009: Add gettext target (GH-119006) (#119074)
7c224dd
Co-authored-by: Rafael Fontenelle <[email protected]>
@rffontenelle
rffontenelle deleted the add-gettext-target branch May 15, 2024 18:40
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@rffontenelle @estyxx
pythongh-119009: Add gettext target (python#119006)
467f210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
+2 more reviewers
@Seluj78 Seluj78 Seluj78 approved these changes
@egeakman egeakman egeakman approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rffontenelle @merwok @hugovk @Seluj78 @egeakman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.