GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Misc improvements to the itertools docs by rhettinger · Pull Request #119040 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented May 14, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Replace variable it with the spelled-out iterator in the rough code equivalents
  • Use yield from instead of an equivalent for-loop
  • More accurate tee() equivalent that uses only a single shared data store
  • Use contextlib.suppress() instead of equivalent try/except. (Suggested by Pochmann).

📚 Documentation preview 📚: https://cpython-previews--119040.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 6 commits May 13, 2024 08:46
@rhettinger
Remove self-evident comment in iter_index
a014894
@rhettinger
Use contextlib.suppress() instead of try/except
c4bfbfb
@rhettinger
Simplify with "yield from"
7b82543
@rhettinger
Simplify with "yield from"
0eb2662
@rhettinger
Replace "it" with "iterable" in places where it helps.
83f367c
@rhettinger
More accurate tee() equivalent with a shared data store
206cd5e
@rhettinger rhettinger added docs Documentation in the Doc dir skip issue skip news labels May 14, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 14, 2024
@rhettinger
Match the "return" style of the other equivalents
4f2b6a8
@rhettinger
rhettinger merged commit 7a97ee5 into python:main May 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 14, 2024
@rhettinger
rhettinger deleted the further_recipe_cleanups branch May 14, 2024 15:18
@rhettinger rhettinger added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 14, 2024
@miss-islington-app

miss-islington-app Bot commented May 14, 2024

Copy link
Copy Markdown

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 14, 2024

Copy link
Copy Markdown

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2024
@rhettinger @miss-islington
Misc improvements to the itertools docs (pythongh-119040)
8ef19e3 
(cherry picked from commit 7a97ee5)

Co-authored-by: Raymond Hettinger <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2024
@rhettinger @miss-islington
Misc improvements to the itertools docs (pythongh-119040)
0e20960 
(cherry picked from commit 7a97ee5)

Co-authored-by: Raymond Hettinger <[email protected]>
@bedevere-app

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

GH-119044 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 14, 2024
@bedevere-app

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

GH-119045 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 14, 2024
rhettinger pushed a commit that referenced this pull request May 14, 2024
@miss-islington
[3.12] Misc improvements to the itertools docs (gh-119040) (#119044)
bac277f
rhettinger pushed a commit that referenced this pull request May 14, 2024
@miss-islington
[3.13] Misc improvements to the itertools docs (gh-119040) (#119045)
8439d09
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@rhettinger @estyxx
Misc improvements to the itertools docs (pythongh-119040)
6921e8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@rhettinger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.