GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable some stricter mypy settings on `Lib/_pyrepl` by AlexWaygood · Pull Request #119077 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 15, 2024

Copy link
Copy Markdown
Member

Some low-hanging fruit I noticed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Enable some stricter mypy settings on Lib/_pyrepl
870337e
@AlexWaygood AlexWaygood added skip issue skip news labels May 15, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 15, 2024
@AlexWaygood AlexWaygood added the topic-repl Related to the interactive shell label May 15, 2024
@AlexWaygood
Add this too
208f5fb
@AlexWaygood
AlexWaygood requested a review from ambv May 15, 2024 18:47
@AlexWaygood
Merge branch 'main' into pyrepl-mypy
b35eb90
@AlexWaygood
AlexWaygood merged commit 0883fd2 into python:main May 20, 2024
@AlexWaygood
AlexWaygood deleted the pyrepl-mypy branch May 20, 2024 12:52
@bedevere-app bedevere-app Bot removed the awaiting core review label May 20, 2024
@lysnikolaou lysnikolaou added the needs backport to 3.13 only security fixes label May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@AlexWaygood @miss-islington
Enable some stricter mypy settings on Lib/_pyrepl (pythonGH-119077)
5b8cb09 
(cherry picked from commit 0883fd2)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119428 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 22, 2024
ambv pushed a commit that referenced this pull request May 22, 2024
@miss-islington @AlexWaygood
[3.13] Enable some stricter mypy settings on Lib/_pyrepl (GH-119077) (
81440c5 
#119428)

(cherry picked from commit 0883fd2)

Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@AlexWaygood @estyxx
Enable some stricter mypy settings on Lib/_pyrepl (python#119077)
98ac47f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.