GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108267: Fix object.__setattr__ regression in dataclasses docs by hauntsaninja · Pull Request #119082 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented May 16, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks to FrozenBob for catching (again)!

Unfortunately the regression was backported to 3.11, which is now in security only: #117005 (comment)

  • Issue: Minor mistake in dataclasses documentation update #108267

📚 Documentation preview 📚: https://cpython-previews--119082.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja
pythongh-108267: Fix object.__setattr__ regression in dataclasses docs
49049e5
@hauntsaninja hauntsaninja added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 16, 2024
@hauntsaninja
hauntsaninja requested a review from ericvsmith as a code owner May 16, 2024 04:47
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels May 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 16, 2024
Minor mistake in dataclasses documentation update #108267
Closed
AlexWaygood
AlexWaygood approved these changes May 16, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 16, 2024
@AlexWaygood
AlexWaygood merged commit 17cba55 into python:main May 16, 2024
@miss-islington-app

miss-islington-app Bot commented May 16, 2024

Copy link
Copy Markdown

Thanks @hauntsaninja for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 16, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2024
@hauntsaninja @miss-islington
pythongh-108267: Fix object.__setattr__ regression in dataclasses docs (
5d11c07 
pythonGH-119082)

(cherry picked from commit 17cba55)

Co-authored-by: Shantanu <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2024
@hauntsaninja @miss-islington
pythongh-108267: Fix object.__setattr__ regression in dataclasses docs (
692179b 
pythonGH-119082)

(cherry picked from commit 17cba55)

Co-authored-by: Shantanu <[email protected]>
@bedevere-app

bedevere-app Bot commented May 16, 2024

Copy link
Copy Markdown

GH-119097 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 16, 2024
@bedevere-app

bedevere-app Bot commented May 16, 2024

Copy link
Copy Markdown

GH-119098 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 16, 2024
AlexWaygood pushed a commit that referenced this pull request May 16, 2024
@miss-islington @hauntsaninja
[3.12] gh-108267: Fix object.__setattr__ regression in dataclasses do…
a3db4e8 
…cs (GH-119082) (#119098)

Co-authored-by: Shantanu <[email protected]>
AlexWaygood pushed a commit that referenced this pull request May 16, 2024
@miss-islington @hauntsaninja
[3.13] gh-108267: Fix object.__setattr__ regression in dataclasses do…
c69fe80 
…cs (GH-119082) (#119097)

Co-authored-by: Shantanu <[email protected]>
@hauntsaninja
hauntsaninja deleted the gh-108267 branch May 16, 2024 15:16
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@hauntsaninja @estyxx
pythongh-108267: Fix object.__setattr__ regression in dataclasses docs (
4926303 
python#119082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hauntsaninja @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.