GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move the comment to the right place where it used to be by abhinav-upadhyay · Pull Request #119085 · python/cpython

Conversation

@abhinav-upadhyay

@abhinav-upadhyay abhinav-upadhyay commented May 16, 2024

Copy link
Copy Markdown
Contributor

In GH-116206, the comment about moving reachable objects to next generation got moved from its original place to a place where there is no code below it.

This PR puts it back where the actual movement of reachable objects happen to the next generation.

(I don't think this is a cosmetic change. The purpose of the comment is to document the code underneath it. Either the code and comments have to be in sync, or the comments need to be fixed to reflect the current reality. In this case, the comment is not quite at the right place, misleading for anyone new reading it or changing that code.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abhinav-upadhyay
Move the comment to the right place where it used to be
fa21e29 
In pythonGH-116206, the comment about moving reachable objects to next generation got moved from its original place to a place where there is no code below it. This PR puts it back where the actual movement of rechable objects happen to the next generation.
@bedevere-app bedevere-app Bot added the awaiting review label May 16, 2024
@abhinav-upadhyay
Remove extra new line to appease lint
59e70e0
@Eclips4 Eclips4 added skip issue skip news labels May 16, 2024
Eclips4
Eclips4 approved these changes May 16, 2024
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 16, 2024
@abhinav-upadhyay

abhinav-upadhyay commented May 18, 2024

Copy link
Copy Markdown
Contributor Author

Can this be merged, or it requires something more?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abhinav-upadhyay
Merge branch 'main' into move-comment
db0d614
@abhinav-upadhyay

abhinav-upadhyay commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@markshannon Maybe you need to review this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abhinav-upadhyay
Merge branch 'main' into move-comment
6c48fba
@picnixz
picnixz requested a review from markshannon August 28, 2024 08:43
@sergey-miryanov

sergey-miryanov commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

@nascheme Please take a look. Maybe we have a change to merge this after yours #136189
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Eclips4 requested a review from nascheme August 7, 2025 18:18
@nascheme
Merge branch 'main' into move-comment
c396bf3
@nascheme
nascheme enabled auto-merge (squash) August 7, 2025 20:09
@nascheme

nascheme commented Aug 7, 2025

Copy link
Copy Markdown
Member

LGTM. I've enabled auto-merge after resolving the merge conflict.
sergey-miryanov and Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nascheme
nascheme merged commit e3ad900 into python:main Aug 7, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 7, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@abhinav-upadhyay @Agent-Hellboy
pythonGH-119085: Move comment in Python/gc.c to correct place.
7bde5d6 
In pythonGH-116206, the comment about moving reachable objects to next generation
got moved from its original place to a place where there is no code below
it. Put the comment back to where the actual movement of reachable objects
happens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes
@markshannon markshannon Awaiting requested review from markshannon
@nascheme nascheme Awaiting requested review from nascheme

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@abhinav-upadhyay @sergey-miryanov @nascheme @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.