GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-119113: Raise `TypeError` from `pathlib.PurePath.with_suffix(None)` by barneygale · Pull Request #119124 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented May 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Restore behaviour from 3.12 when path.with_suffix(None) is called.

  • Issue: pathlib.Path.with_suffix(None) became allowed in Python 3.13b1 #119113

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@barneygale
pythonGH-119113: Raise TypeError on `pathlib.PurePath.with_suffix(N…
ad0cf26
…one)`

Restore behaviour from 3.12 when `path.with_suffix(None)` is called.
@barneygale barneygale added topic-pathlib needs backport to 3.13 only security fixes labels May 17, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 17, 2024
pathlib.Path.with_suffix(None) became allowed in Python 3.13b1 #119113
Closed
barneygale
barneygale commented May 17, 2024
View reviewed changes
Comment thread Lib/pathlib/_abc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@barneygale
barneygale merged commit 3c28510 into python:main May 19, 2024
@miss-islington-app

miss-islington-app Bot commented May 19, 2024

Copy link
Copy Markdown

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label May 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2024
@barneygale @miss-islington
pythonGH-119113: Raise TypeError from `pathlib.PurePath.with_suffix…
5d80e48
…(None)` (pythonGH-119124)

Restore behaviour from 3.12 when `path.with_suffix(None)` is called.
(cherry picked from commit 3c28510)

Co-authored-by: Barney Gale <[email protected]>
@bedevere-app

bedevere-app Bot commented May 19, 2024

Copy link
Copy Markdown

GH-119183 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 19, 2024
barneygale added a commit that referenced this pull request May 19, 2024
@miss-islington @barneygale
[3.13] GH-119113: Raise TypeError from `pathlib.PurePath.with_suffi…
27b61c1
…x(None)` (GH-119124) (#119183)

Restore behaviour from 3.12 when `path.with_suffix(None)` is called.
(cherry picked from commit 3c28510)

Co-authored-by: Barney Gale <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@barneygale @estyxx
pythonGH-119113: Raise TypeError from `pathlib.PurePath.with_suffix…
ed048f2
…(None)` (python#119124)

Restore behaviour from 3.12 when `path.with_suffix(None)` is called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.