GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-119132: Update sys.version to identify free-threaded or not. by corona10 · Pull Request #119134 · python/cpython Conversation
|
|
Could we maybe leave out "default" for the normal build? It doesn't really add value: The tests on GitHub don't include "(default)" either. Maybe even like this: This could even work for |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You still need to update this: Lines 1156 to 1161 in 81c3130
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Currently this test is failing: cpython/Lib/test/test_platform.py Line 129 in 81c3130
Do you have an opinion on not including "default"? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Hey, I am under testing. Would you like to leave a comment once I convert the PR into the official PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Old regex: ([\w.+]+)\s*\(#?([^,]+)(?:,\s*([\w ]*)(?:,\s*([\w :]*))?)?\)\s*\[([^\]]+)\]? New regex: ([\w.+]+)\s*\(#?([^,]+)(?:,\s*([\w ]*)(?:,\s*([\w :]*))?)(?:,\s*(free-threading))?\)*\s*\[([^\]]+)\]? Unmatched string: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Nice Zombies <[email protected]>
There was an error while loading. Please reload this page.
Co-authored-by: Nice Zombies <[email protected]>
|
@nineteendo Thanks for the comment Still issue (nah I am really bad at regex) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I proposed a similar idea last August, but it was rejected at that time: #108239 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I suggest to mention The "(...)" part of sys.version is the Git information, I would prefer to not touch it. If we change sys.version, I would prefer to "add a new field" in sys.version. For example, add The drawback of changing |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Then we need to discuss with @hugovk |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You accidentally added -([\w.+]+)\s*\(#?([^,]+)(?:,\s*([\w ]*)(?:,\s*([\w :]*))?)?(?:,\s*(free-threading))?\)*\s*\[([^\]]+)\]? +([\w.+]+)\s*\(#?([^,]+)(?:,\s*([\w ]*)(?:,\s*([\w :]*))?)?(?:,\s*(free-threading))?\)\s*\[([^\]]+)\]? But I would prefer a new field as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@Yhg1s What do you think about backporting it into the 3.13 since it will help the free-threading ecosystem? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but see my comment on regex.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…pythongh-119134) (cherry picked from commit c141d43) Co-authored-by: Donghee Na <[email protected]>
|
GH-119153 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, I haven't been paying close attention, but was there a decision not to tweak It seems that since it's a named tuple there'd be little problem adding a new field which distinguishes the two builds. Something like: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
build information is not part of version_info. the version string is meant for humans and includes other detailed things that are also not in version_info such as compiler details. there's the https://docs.python.org/3.13/library/sys.html#sys._is_gil_enabled may-change-in-the-future API for people wanting to know the current status of the GIL regardless of build type. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks. Just checking. As long as there is somewhere to query the status at run-time without parsing a human-readable string. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.