GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Minor improvements to the docs for itertools.tee() by rhettinger · Pull Request #119135 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented May 18, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Rename variable from empty_link to the more descriptive `shared_link'.
  • Hoist the try/except outside of the inner loop.

📚 Documentation preview 📚: https://cpython-previews--119135.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 2 commits May 16, 2024 21:05
@rhettinger
Move try/except out of the inner loop.
6f7d1e9
@rhettinger
Rename to "shared_link"
3bba6d8
@rhettinger rhettinger added docs Documentation in the Doc dir skip issue skip news labels May 18, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 18, 2024
rhettinger added 2 commits May 18, 2024 01:12
@rhettinger
Simpler but slightly slower code
0758bbe
@rhettinger
.
8a8a142
@rhettinger rhettinger added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 18, 2024
@rhettinger
rhettinger merged commit 81c3130 into python:main May 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 18, 2024
@miss-islington-app

miss-islington-app Bot commented May 18, 2024

Copy link
Copy Markdown

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger deleted the itertools_docs branch May 18, 2024 06:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@rhettinger @miss-islington
Minor improvements to the docs for itertools.tee() (pythongh-119135)
d544a97 
(cherry picked from commit 81c3130)

Co-authored-by: Raymond Hettinger <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@rhettinger @miss-islington
Minor improvements to the docs for itertools.tee() (pythongh-119135)
525e7ef 
(cherry picked from commit 81c3130)

Co-authored-by: Raymond Hettinger <[email protected]>
@bedevere-app

bedevere-app Bot commented May 18, 2024

Copy link
Copy Markdown

GH-119136 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 18, 2024
@bedevere-app

bedevere-app Bot commented May 18, 2024

Copy link
Copy Markdown

GH-119137 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 18, 2024
rhettinger pushed a commit that referenced this pull request May 18, 2024
@miss-islington
[3.13] Minor improvements to the docs for itertools.tee() (gh-119135) (…
374655f 
…gh-119136)
rhettinger pushed a commit that referenced this pull request May 18, 2024
@miss-islington
[3.12] Minor improvements to the docs for itertools.tee() (gh-119135) (…
a370eeb 
…gh-119137)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@rhettinger @estyxx
Minor improvements to the docs for itertools.tee() (pythongh-119135)
8f1ee90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@rhettinger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.