GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119050: Add type hints to libregrtest/results.py by vstinner · Pull Request #119144 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Sort also 'omitted' in TestResults.display_result().

  • Issue: Add the --duration option to the test suite #119050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-119050: Add type hints to libregrtest/results.py
bbab1f6 
Sort also 'omitted' in TestResults.display_result().
@vstinner vstinner added the skip news label May 18, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 18, 2024
Add the --duration option to the test suite #119050
Closed
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed awaiting core review labels May 18, 2024
Eclips4
Eclips4 approved these changes May 18, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting core review label May 18, 2024
@vstinner
vstinner merged commit 30b4e9f into python:main May 18, 2024
@vstinner
vstinner deleted the regrtest_typing branch May 18, 2024 20:21
@miss-islington-app

miss-islington-app Bot commented May 18, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 18, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@vstinner @miss-islington
pythongh-119050: Add type hints to libregrtest/results.py (pythonGH-1…
a4d2fb4 
…19144)

Sort also 'omitted' in TestResults.display_result().
(cherry picked from commit 30b4e9f)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@vstinner @miss-islington
pythongh-119050: Add type hints to libregrtest/results.py (pythonGH-1…
10b802f 
…19144)

Sort also 'omitted' in TestResults.display_result().
(cherry picked from commit 30b4e9f)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented May 18, 2024

Copy link
Copy Markdown

GH-119156 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 18, 2024
@bedevere-app

bedevere-app Bot commented May 18, 2024

Copy link
Copy Markdown

GH-119157 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 18, 2024
@vstinner

vstinner commented May 18, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request May 18, 2024
@miss-islington @vstinner
[3.13] gh-119050: Add type hints to libregrtest/results.py (GH-119144) (
9129614 
#119156)

gh-119050: Add type hints to libregrtest/results.py (GH-119144)

Sort also 'omitted' in TestResults.display_result().
(cherry picked from commit 30b4e9f)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request May 18, 2024
@miss-islington @vstinner
[3.12] gh-119050: Add type hints to libregrtest/results.py (GH-119144) (
d76d95e 
#119157)

gh-119050: Add type hints to libregrtest/results.py (GH-119144)

Sort also 'omitted' in TestResults.display_result().
(cherry picked from commit 30b4e9f)

Co-authored-by: Victor Stinner <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119050: Add type hints to libregrtest/results.py (python#119144
63e27ae 
)

Sort also 'omitted' in TestResults.display_result().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.