GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110383: Document `socket.makefile()` accepts combined modes by squeakyboots · Pull Request #119150 · python/cpython

Conversation

@squeakyboots

@squeakyboots squeakyboots commented May 18, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

ref: #110383
ref: https://mail.python.org/archives/list/[email protected]/thread/3VGLA6Q6QDYB7XIAHFIRAVW4TQSEAZGA/

  • Issue: Issues from [email protected] #110383

📚 Documentation preview 📚: https://cpython-previews--119150.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@squeakyboots
Document socket.makefile() accepts combined modes
fc72329 
ref: python#110383
ref: https://mail.python.org/archives/list/[email protected]/thread/3VGLA6Q6QDYB7XIAHFIRAVW4TQSEAZGA/
@ghost

ghost commented May 18, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 18, 2024
Issues from [email protected] #110383
Closed
erlend-aasland
erlend-aasland reviewed May 18, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the docstring in Lib/socket.py as well, so they are synchronised?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
squeakyboots added 3 commits May 20, 2024 11:46
@squeakyboots
Merge branch 'python:main' into socket.makefile-doc-modes
2e8d690
@squeakyboots
Merge branch 'python:main' into socket.makefile-doc-modes
81f461e
@squeakyboots
Document socket.makefile() accepts combined modes in Lib/socket.py
20ded2e
erlend-aasland
erlend-aasland approved these changes May 21, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 21, 2024
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 21, 2024
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 21, 2024 16:05
@erlend-aasland
erlend-aasland merged commit 62a29be into python:main May 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@squeakyboots @miss-islington
pythongh-110383: Document socket.makefile() accepts combined modes (p…
ba3d993 
…ythonGH-119150)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@squeakyboots @miss-islington
pythongh-110383: Document socket.makefile() accepts combined modes (p…
9549730 
…ythonGH-119150)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <[email protected]>
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119324 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 21, 2024
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119325 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 21, 2024
erlend-aasland pushed a commit that referenced this pull request May 21, 2024
@miss-islington @squeakyboots
[3.13] gh-110383: Document socket.makefile() accepts combined modes (…
256b791 
…GH-119150) (#119324)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <[email protected]>
erlend-aasland pushed a commit that referenced this pull request May 21, 2024
@miss-islington @squeakyboots
[3.12] gh-110383: Document socket.makefile() accepts combined modes (…
a1c2052 
…GH-119150) (#119325)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <[email protected]>
@squeakyboots
squeakyboots deleted the socket.makefile-doc-modes branch May 22, 2024 13:47
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@squeakyboots @estyxx
pythongh-110383: Document socket.makefile() accepts combined modes (p…
2a9aed3 
…ython#119150)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@squeakyboots @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.