GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111997: Fix argument count for LINE event and clarify type of argument counts. by scoder · Pull Request #119179 · python/cpython

Conversation

@scoder

@scoder scoder commented May 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

According to the documentation, the LINE event does not pass the offset but only the line number:

https://docs.python.org/3.13/library/sys.monitoring.html#callback-function-arguments

It's unclear whether the PyMonitoring_FireLineEvent() function should be passed an offset then, but it's probably ok for consistency with the other PyMonitoring_Fire* functions.

  • Issue: C-API for signalling monitoring events #111997

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@scoder
Fix argument count for LINE event and clarify type of argument counts.
608992d
@scoder scoder added the needs backport to 3.13 only security fixes label May 19, 2024
@scoder
scoder requested review from iritkatriel and markshannon May 19, 2024 14:48
@bedevere-app bedevere-app Bot added the awaiting core review label May 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2024
C-API for signalling monitoring events #111997
Closed
@scoder
Special case the LINE event since there are also other events with 2 …
41f7bc9 
…arguments.
@scoder

scoder commented May 25, 2024

Copy link
Copy Markdown
Contributor Author

@iritkatriel @markshannon CI passes, ready for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes May 26, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 26, 2024
@iritkatriel
iritkatriel enabled auto-merge (squash) May 26, 2024 09:19
@scoder scoder added the skip news label May 26, 2024
@iritkatriel
iritkatriel merged commit 70b07aa into python:main May 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 26, 2024
@miss-islington-app

miss-islington-app Bot commented May 26, 2024

Copy link
Copy Markdown

Thanks @scoder for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2024
@scoder @miss-islington
pythongh-111997: Fix argument count for LINE event and clarify type o…
b68915f 
…f argument counts. (pythonGH-119179)

(cherry picked from commit 70b07aa)

Co-authored-by: scoder <[email protected]>
@bedevere-app

bedevere-app Bot commented May 26, 2024

Copy link
Copy Markdown

GH-119575 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 26, 2024
scoder added a commit that referenced this pull request May 26, 2024
@miss-islington @scoder
[3.13] gh-111997: Fix argument count for LINE event and clarify type …
825a5ae 
…of argument counts. (GH-119179) (GH-119575)

gh-111997: Fix argument count for LINE event and clarify type of argument counts. (GH-119179)
(cherry picked from commit 70b07aa)

Co-authored-by: scoder <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@scoder @estyxx
pythongh-111997: Fix argument count for LINE event and clarify type o…
4b9f326 
…f argument counts. (python#119179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@scoder @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.