GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: Fall back to bundled libmpdec if system libmpdec is not found by erlend-aasland · Pull Request #119196 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor 
$ brew unlink libmpdec
$ ./configure --with-system-libmpdec | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... no
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
checking for --with-decimal-contextvar... yes
checking for decimal libmpdec machine... universal
checking for stdlib extension module _decimal... yes
$ grep 'DECIMAL_.*FLAGS' Makefile
MODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1
MODULE__DECIMAL_LDFLAGS=-lm $(LIBMPDEC_A)

$ ./configure | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... no
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
checking for --with-decimal-contextvar... yes
checking for decimal libmpdec machine... universal
checking for stdlib extension module _decimal... yes
$ grep 'DECIMAL_.*FLAGS' Makefile
MODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1
MODULE__DECIMAL_LDFLAGS=-lm $(LIBMPDEC_A)

$ ./configure --without-system-libmpdec | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... no
configure: WARNING: the bundled copy of libmpdecimal is scheduled for removal in Python 3.15; consider using a system installed mpdecimal library.
checking for --with-decimal-contextvar... yes
checking for decimal libmpdec machine... universal
checking for stdlib extension module _decimal... yes
$ grep ‘DECIMAL_.*FLAGS’ Makefile
MODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1
MODULE__DECIMAL_LDFLAGS=-lm $(LIBMPDEC_A)

$ brew link libmpdec
$ ./configure --with-system-libmpdec | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... yes
checking for --with-decimal-contextvar... yes
checking for stdlib extension module _decimal... yes
$ grep ‘DECIMAL_.*FLAGS’ Makefile
MODULE__DECIMAL_CFLAGS=-I/opt/homebrew/Cellar/mpdecimal/4.0.0/include
MODULE__DECIMAL_LDFLAGS=-L/opt/homebrew/Cellar/mpdecimal/4.0.0/lib -lmpdec -lm
  • Issue: Unvendor libmpdec sources #115119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-115119: Fall back to bundled libmpdec if system libmpdec is …
c537d8b 
…not found
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner May 20, 2024 02:55
@erlend-aasland erlend-aasland added the needs backport to 3.13 only security fixes label May 20, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2024
Unvendor libmpdec sources #115119
Closed
15 tasks done
@erlend-aasland
erlend-aasland requested review from ned-deily and zware May 20, 2024 02:56
This was referenced May 20, 2024
Try to repair oddball test bots timing out in test_int #119166
Merged
Libmpec-dev not available on debian 12 when building Python #119114
Closed
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 20, 2024
@bedevere-bot

bedevere-bot commented May 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit c537d8b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 20, 2024
ned-deily
ned-deily approved these changes May 20, 2024
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 20, 2024
@erlend-aasland

erlend-aasland commented May 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Ned! FTR, the buildbot failures all seem unrelated1

Footnotes

  1. buildbot/PPC64LE Fedora Stable Refleaks PR is another regression I introduced in sqlite3; PR is already up merged 😄 ↩
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

I'll wait for Zach to chime in before landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 20, 2024

Copy link
Copy Markdown
Member

cc @hroncok who had issues with this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

Merging, as per Ned's comment on Discord.
ned-deily reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 642b25b into python:main May 20, 2024
@erlend-aasland
erlend-aasland deleted the libmpdec-fallback branch May 20, 2024 14:58
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@erlend-aasland @miss-islington
pythongh-115119: Fall back to bundled libmpdec if system libmpdec is …
f007dae 
…not found (pythonGH-119196)

(cherry picked from commit 642b25b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119217 is a backport of this pull request to the 3.13 branch.
ned-deily reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2024
erlend-aasland
erlend-aasland commented May 20, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2024-05-19-22-54-55.gh-issue-115119.DwMwev.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 20, 2024
@erlend-aasland
Amend NEWS category for pythongh-119196
7d0c79d
erlend-aasland added a commit that referenced this pull request May 20, 2024
@erlend-aasland
Amend NEWS category for gh-119196 (#119218)
6f7dd0a
erlend-aasland added a commit that referenced this pull request May 20, 2024
@miss-islington @erlend-aasland
[3.13] gh-115119: Fall back to bundled libmpdec if system libmpdec is…
e370b64 
… not found (GH-119196) (#119217)

(cherry picked from commit 642b25b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@erlend-aasland @estyxx
pythongh-115119: Fall back to bundled libmpdec if system libmpdec is …
b1d0a78 
…not found (python#119196)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@erlend-aasland @estyxx
Amend NEWS category for pythongh-119196 (python#119218)
15aef31
@hughsw hughsw mentioned this pull request Aug 14, 2024
Update setup-building.rst with a note about libmpdec-dev missing from some Debian versions python/devguide#1371
Merged
@skirpichev skirpichev mentioned this pull request Oct 12, 2025
Only pure Python decimal module is used in Python 3.15 on Ubuntu #139994
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@zware zware Awaiting requested review from zware

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @vstinner @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.