GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typing docs: Fix formatting issue by davidfstr · Pull Request #119210 · python/cpython

Conversation

@davidfstr

@davidfstr davidfstr commented May 20, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix an RST formatting issue. See screenshots below for details:

Before:
before

After:
after

📚 Documentation preview 📚: https://cpython-previews--119210.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@davidfstr
typing docs: Fix formatting issue
3909c2a
@davidfstr
davidfstr requested review from AlexWaygood and JelleZijlstra as code owners May 20, 2024 14:15
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 20, 2024
@JelleZijlstra JelleZijlstra added the needs backport to 3.13 only security fixes label May 20, 2024
JelleZijlstra
JelleZijlstra approved these changes May 20, 2024
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 20, 2024
@JelleZijlstra JelleZijlstra added the skip issue label May 20, 2024
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) May 20, 2024 14:22
@JelleZijlstra
JelleZijlstra merged commit 72d07dd into python:main May 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2024
@miss-islington-app

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @davidfstr for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@davidfstr @miss-islington
typing docs: Fix formatting issue (pythonGH-119210)
97a37d4 
(cherry picked from commit 72d07dd)

Co-authored-by: David Foster <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119212 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2024
AlexWaygood pushed a commit that referenced this pull request May 20, 2024
@miss-islington @davidfstr
[3.13] typing docs: Fix formatting issue (GH-119210) (#119212)
cbf064b 
typing docs: Fix formatting issue (GH-119210)
(cherry picked from commit 72d07dd)

Co-authored-by: David Foster <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@davidfstr @estyxx
typing docs: Fix formatting issue (python#119210)
5c48fde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davidfstr @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.