GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119205: Fix autocompletion bug in new repl by koxudaxi · Pull Request #119229 · python/cpython

Conversation

@koxudaxi

@koxudaxi koxudaxi commented May 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

If the interpreter shows a warning, the new repl prompt cursor moves after the warning.

  • Issue: Warning on autocomplete messes up the terminal #119205

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@koxudaxi
pythongh-119205: Fix autocompletion bug in new repl
8a0241f
@ghost

ghost commented May 20, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting review label May 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2024
Warning on autocomplete messes up the terminal #119205
Closed
@koxudaxi
Merge branch 'main' into fix-issue-119205
05c271b
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

blurb-it Bot and others added 8 commits May 20, 2024 16:16
@blurb-it
📜🤖 Added by blurb_it.
852cd53
@koxudaxi
pythongh-119205: Add unittest
f9ee809
@koxudaxi
Merge branch 'main' into fix-issue-119205
22cdb57
@koxudaxi
pythongh-119205: revert unnecessary changes
241e634
@koxudaxi
pythongh-119205: revert unnecessary changes
e5f1575
@koxudaxi
pythongh-119205: Improve unittest
b2f1b02
@koxudaxi
pythongh-119205: Improve suppression warning
6509c29
@koxudaxi
Merge branch 'main' into fix-issue-119205
3d41951
@lysnikolaou

lysnikolaou commented May 21, 2024

Copy link
Copy Markdown
Member

@koxudaxi Can you please rebase onto main and move the tests to the newly created test_pyrepl directory?

koxudaxi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv
Merge branch 'main' into fix-issue-119205
e8988b8
@ambv
ambv requested a review from rhettinger as a code owner May 21, 2024 18:46
lysnikolaou
lysnikolaou approved these changes May 21, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 21, 2024
@ambv
Remove news
fe484c7
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv added the skip news label May 21, 2024
@lysnikolaou lysnikolaou added the topic-repl Related to the interactive shell label May 21, 2024
@koxudaxi
Merge branch 'main' into fix-issue-119205
a1e81f5
@ambv
ambv enabled auto-merge (squash) May 21, 2024 19:12
@koxudaxi

koxudaxi commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

@ambv @lysnikolaou
Thank you for reviewing and rebasing my PR.
I apologize I was moving to Pittsburgh airport from the conference center.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

koxudaxi added 2 commits May 21, 2024 15:31
@koxudaxi
Merge branch 'main' into fix-issue-119205
159f9d8
@koxudaxi
Merge branch 'main' into fix-issue-119205
11c3a18
@ambv

ambv commented May 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@koxudaxi let the tests complete, don't rebase unless there are conflicts.

koxudaxi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv
ambv merged commit 506b1a3 into python:main May 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2024
@koxudaxi
koxudaxi deleted the fix-issue-119205 branch May 21, 2024 23:35
@bedevere-bot

bedevere-bot commented May 22, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 506b1a3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/8076) and take a look at the build logs.
  4. Check if the failure is related to this commit (506b1a3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/8076

Summary of the results of the build (if available):

Click to see traceback logs
Note: switching to '506b1a3ff66a41c72d205c8e4cba574e439d8e76'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 506b1a3ff6 gh-119205: Fix autocompletion bug in new repl (#119229)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** wait: No child processes.  Stop.
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes.  Stop.

Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented May 22, 2024

Copy link
Copy Markdown
Contributor

The buildbot failure is an unrelated timeout:

command timed out: 1800 seconds without output running [b'make', b'buildbottest', b'TESTOPTS=-j2 --junit-xml test-results.xml ${BUILDBOT_TESTOPTS}', b'TESTPYTHONOPTS=', b'TESTTIMEOUT=1200'], attempting to kill
koxudaxi reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lysnikolaou lysnikolaou added the needs backport to 3.13 only security fixes label May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @koxudaxi for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

koxudaxi reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@koxudaxi @ambv @miss-islington
pythongh-119205: Fix autocompletion bug in new repl (pythonGH-119229)
9dd2ae8
(cherry picked from commit 506b1a3)

Co-authored-by: Koudai Aono <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119407 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 22, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
@miss-islington @koxudaxi @ambv
[3.13] gh-119205: Fix autocompletion bug in new repl (GH-119229) (#11…
eafd633
…9407)

(cherry picked from commit 506b1a3)

Co-authored-by: Koudai Aono <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@koxudaxi @ambv @estyxx
pythongh-119205: Fix autocompletion bug in new repl (python#119229)
7728f85
Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@koxudaxi @lysnikolaou @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.