GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide by shaunagm · Pull Request #119232 · python/cpython

Conversation

@shaunagm

@shaunagm shaunagm commented May 20, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Note: I am a first-time contributor, so apologies if I've missed some important norms or processes.

This is an attempt to fix #118912 by removing the description of a bug that was removed in Python 3.5. I noticed that elsewhere in the documentation there were comments about when something had been added or removed or changed, so I tried using that here. Not sure if that was actually appropriate.

I had one other question: the autospeccing guide feels a little out of place here. Everything else seems to be primarily for reference, while this guide feels like more of a howto. Should it be moved to a howto section, and merely linked here? If we want to keep it in this part of the docs, should it be moved next to create_autospec or even submerged into it? Eager to get your thoughts on this question, and to get overall feedback on this PR.

  • Issue: Inappropriateness in unittest documentation with actual behavior #118912

📚 Documentation preview 📚: https://cpython-previews--119232.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shaunagm
Remove description of issue fixed in 3.5 from autospeccing guide
09b2503
@ghost

ghost commented May 20, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2024
Inappropriateness in unittest documentation with actual behavior #118912
Closed
shaunagm added 3 commits May 20, 2024 14:15
@shaunagm
Make autospeccing note text more succint and lint whitespace
71aabe8
@shaunagm
Add linting changes (missed in last commit)
05b3d50
@shaunagm
Merge branch 'main' into update-mock-autospec-docs
c7f90a6
nedbat
nedbat approved these changes May 20, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 20, 2024
willingc
willingc approved these changes May 20, 2024
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaunagm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shaunagm reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 20, 2024
@willingc
Merge branch 'main' into update-mock-autospec-docs
0b0ba7a
@willingc
willingc enabled auto-merge (squash) May 20, 2024 19:43
@willingc
willingc merged commit 7e57640 into python:main May 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2024
@willingc willingc added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 20, 2024
@miss-islington-app

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @shaunagm for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @shaunagm for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@shaunagm @willingc @miss-islington
pythongh-118912: Remove description of issue fixed in 3.5 from autosp…
d86ae9c 
…eccing guide (pythonGH-119232)

* Remove description of issue fixed in 3.5 from autospeccing guide

* Make autospeccing note text more succint and lint whitespace

* Add linting changes (missed in last commit)

---------

(cherry picked from commit 7e57640)

Co-authored-by: Shauna <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@shaunagm @willingc @miss-islington
pythongh-118912: Remove description of issue fixed in 3.5 from autosp…
96e5553 
…eccing guide (pythonGH-119232)

* Remove description of issue fixed in 3.5 from autospeccing guide

* Make autospeccing note text more succint and lint whitespace

* Add linting changes (missed in last commit)

---------

(cherry picked from commit 7e57640)

Co-authored-by: Shauna <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119283 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 20, 2024
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119284 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2024
willingc added a commit that referenced this pull request May 20, 2024
@miss-islington @shaunagm @willingc
[3.12] gh-118912: Remove description of issue fixed in 3.5 from autos…
d8981ab 
…peccing guide (GH-119232) (#119283)

gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide (GH-119232)

* Remove description of issue fixed in 3.5 from autospeccing guide

* Make autospeccing note text more succint and lint whitespace

* Add linting changes (missed in last commit)

---------

(cherry picked from commit 7e57640)

Co-authored-by: Shauna <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
willingc added a commit that referenced this pull request May 20, 2024
@miss-islington @shaunagm @willingc
[3.13] gh-118912: Remove description of issue fixed in 3.5 from autos…
24b0e8d 
…peccing guide (GH-119232) (#119284)

gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide (GH-119232)

* Remove description of issue fixed in 3.5 from autospeccing guide

* Make autospeccing note text more succint and lint whitespace

* Add linting changes (missed in last commit)

---------

(cherry picked from commit 7e57640)

Co-authored-by: Shauna <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@shaunagm @willingc @estyxx
pythongh-118912: Remove description of issue fixed in 3.5 from autosp…
b03e63c 
…eccing guide (python#119232)

* Remove description of issue fixed in 3.5 from autospeccing guide

* Make autospeccing note text more succint and lint whitespace

* Add linting changes (missed in last commit)

---------

Co-authored-by: Carol Willing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedbat nedbat nedbat approved these changes
@willingc willingc willingc approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inappropriateness in unittest documentation with actual behavior

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shaunagm @nedbat @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.