GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context (GH-119222) by miss-islington · Pull Request #119263 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) [email protected]

  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mjdominus @miss-islington
pythongh-94808: Add test coverage for "starred kind" in _PyPegen_set_…
d664373 
…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <[email protected]>
@ghost

ghost commented May 20, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels May 20, 2024
This was referenced May 20, 2024
Metabug: Improving C-level coverage #94808
Open
gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context #119222
Merged
@bedevere-app bedevere-app Bot added the skip news label May 20, 2024
@encukou
encukou enabled auto-merge (squash) May 21, 2024 17:17
@encukou

encukou commented Jun 4, 2024

Copy link
Copy Markdown
Member

This is weird -- the bot thinks the CLA isn't signed, but it did allow #119222 with the same address.
@ambv, does this situation seem familiar?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

@encukou, as seen in https://patch-diff.githubusercontent.com/raw/python/cpython/pull/119222.patch, this was a different email address.
encukou reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jun 5, 2024

Copy link
Copy Markdown
Member

@mjdominus, would you mind signing the CLA for your second e-mail too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 18359f2 into python:3.13 Jun 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 7, 2024
@mjdominus

mjdominus commented Jun 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Done, sorry for the confusion. @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington deleted the backport-8231a24-3.13 branch January 2, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @encukou @ambv @mjdominus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.