GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context by mjdominus · Pull Request #119222 · python/cpython

Conversation

mjdominus commented May 20, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

That item is on the gh-94808 checklist, but not checked off. I ran lcov to confirm that the branch was not covered, added and ran the test, and rebuilt the coverage report to confirm that the branch had now been covered.

This pertains to the production

star_target[expr_ty] (memo):
    | '*' a=(!'*' star_target) {
        _PyAST_Starred(CHECK(expr_ty, _PyPegen_set_expr_context(p, a, Store)), Store,
 EXTRA) }
    | target_with_star_atom

at line 1057 in python.gram.

Thanks to @encukou for much guidance through this process.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add test coverage for "starred kind" in _PyPegen_set_expr_context

d702788

bedevere-app Bot added the tests Tests in the Lib/test dir label

May 20, 2024

bedevere-app Bot commented May 20, 2024

Copy link

Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting review label

May 20, 2024

mjdominus changed the title ~~Add test coverage for "starred kind" in _PyPegen_set_expr_context~~ gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

May 20, 2024

bedevere-app Bot mentioned this pull request

May 20, 2024

Metabug: Improving C-level coverage #94808

Open

mjdominus changed the title ~~gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context~~ # gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

May 20, 2024

mjdominus changed the title ~~# gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context~~ #gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

May 20, 2024

encukou changed the title ~~#gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context~~ gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

May 20, 2024

encukou added the skip news label

May 20, 2024

encukou approved these changes

May 20, 2024

View reviewed changes

encukou left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

May 20, 2024

encukou enabled auto-merge (squash)

May 20, 2024 20:24

encukou added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

May 20, 2024

encukou merged commit 8231a24 into python:main

May 20, 2024

bedevere-app Bot removed the awaiting merge label

May 20, 2024

miss-islington-app Bot commented May 20, 2024

Copy link

Copy Markdown

Thanks @mjdominus for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 20, 2024


          pythongh-94808: Add test coverage for "starred kind" in _PyPegen_set_…

d664373

…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 20, 2024


          pythongh-94808: Add test coverage for "starred kind" in _PyPegen_set_…

e4ed7db

…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <[email protected]>

bedevere-app Bot commented May 20, 2024

Copy link

Copy Markdown

GH-119263 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

May 20, 2024

bedevere-app Bot commented May 20, 2024

Copy link

Copy Markdown

GH-119264 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

May 20, 2024

mjdominus deleted the mjd branch

May 22, 2024 03:05

encukou mentioned this pull request

Jun 4, 2024

[3.13] gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context (GH-119222) #119263

Merged

encukou pushed a commit that referenced this pull request

Jun 7, 2024


          [3.13] gh-94808: Add test coverage for "starred kind" in _PyPegen_set…

18359f2

…_expr_context (GH-119222) (GH-119263)

gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context (GH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <[email protected]>

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024


          pythongh-94808: Add test coverage for "starred kind" in _PyPegen_set_…

067e2ea

…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context

encukou pushed a commit that referenced this pull request

Sep 16, 2024


          [3.12] gh-94808: Add test coverage for "starred kind" in _PyPegen_set…

3f5d18d

…_expr_context (GH-119222) (GH-119264)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>

Reviewers

encukou

encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mjdominus commented May 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

Uh oh!

bedevere-app Bot commented May 20, 2024

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented May 20, 2024

Uh oh!

bedevere-app Bot commented May 20, 2024

Uh oh!

bedevere-app Bot commented May 20, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mjdominus commented May 20, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.