GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use `fail-fast: false` in `mypy.yml` by sobolevn · Pull Request #119297 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 21, 2024

Copy link
Copy Markdown
Member

I think it makes sense not to cancel all other mypy builds if one fails.

See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
Use fail-fast: false in mypy.yml
334feca 
I think it makes sense not to cancel all other mypy builds if one fails.

See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
@sobolevn
sobolevn requested a review from AlexWaygood May 21, 2024 08:47
@sobolevn
sobolevn requested review from ezio-melotti and hugovk as code owners May 21, 2024 08:47
@bedevere-app bedevere-app Bot added the awaiting core review label May 21, 2024
@sobolevn sobolevn added skip issue skip news labels May 21, 2024
hugovk
hugovk approved these changes May 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 21, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 21, 2024
@AlexWaygood
AlexWaygood merged commit b365332 into python:main May 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2024
@miss-islington-app

miss-islington-app Bot commented May 21, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@sobolevn @miss-islington
Use fail-fast: false in mypy.yml (pythonGH-119297)
d326f24 
See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actionsGH-jobsjob_idstrategyfail-fast
(cherry picked from commit b365332)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington-app

miss-islington-app Bot commented May 21, 2024

Copy link
Copy Markdown

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b36533290608aed757f6eb16869a679650d32e17 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned AlexWaygood May 21, 2024
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119304 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 21, 2024
AlexWaygood pushed a commit that referenced this pull request May 21, 2024
@miss-islington @sobolevn
[3.13] Use fail-fast: false in mypy.yml (GH-119297) (#119304)
49ad4d0 
Use `fail-fast: false` in `mypy.yml` (GH-119297)

See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actionsGH-jobsjob_idstrategyfail-fast
(cherry picked from commit b365332)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn

sobolevn commented May 21, 2024

Copy link
Copy Markdown
Member Author

3.12 does not have this code: https://github.com/python/cpython/blob/3.12/.github/workflows/mypy.yml
AlexWaygood and hugovk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood removed the needs backport to 3.12 only security fixes label May 21, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
Use fail-fast: false in mypy.yml (python#119297)
335dd86 
See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.