GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119189: Add yet more tests for mixed Fraction arithmetic by serhiy-storchaka · Pull Request #119298 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I have a branch which changes some details of mixed Fraction arithmetic. Some of changes were still not covered by previous tests.

  • Issue: Fraction wrongfully gets casted into float when given as argument to __rpow__ #119189

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-119189: Add yet more tests for mixed Fraction arithmethic
371a8f0
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 21, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from mdickinson May 21, 2024 09:19
@bedevere-app bedevere-app Bot added the awaiting core review label May 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
Fraction wrongfully gets casted into float when given as argument to __rpow__ #119189
Closed
mdickinson
mdickinson approved these changes May 21, 2024
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 21, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 10b1bd9 into python:main May 21, 2024
@miss-islington-app

miss-islington-app Bot commented May 21, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2024
@serhiy-storchaka
serhiy-storchaka deleted the tests-fractions-mixed-arithmetic2 branch May 21, 2024 19:28
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@serhiy-storchaka @miss-islington
pythongh-119189: Add yet more tests for mixed Fraction arithmetic (py…
c0e8fe8 
…thonGH-119298)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@serhiy-storchaka @miss-islington
pythongh-119189: Add yet more tests for mixed Fraction arithmetic (py…
7ffcf54 
…thonGH-119298)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119346 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 21, 2024
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119347 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 21, 2024
serhiy-storchaka added a commit that referenced this pull request May 21, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-119189: Add yet more tests for mixed Fraction arithmetic (G…
47b09d2 
…H-119298) (GH-119347)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request May 22, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-119189: Add yet more tests for mixed Fraction arithmetic (G…
ec484b6 
…H-119298) (GH-119346)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-119189: Add yet more tests for mixed Fraction arithmetic (py…
de7bcf9 
…thonGH-119298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mdickinson mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @mdickinson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.