GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119306: Break up _pyrepl tests by eugenetriguba · Pull Request #119307 · python/cpython

Conversation

@eugenetriguba

@eugenetriguba eugenetriguba commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This breaks up the test_pyrepl.py file into separate files to make it easier to continue adding more tests too without having one incredibly long file to try to manage.

  • Issue: Break up _pyrepl tests #119306

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eugenetriguba
Break up _pyrepl tests
be3e862
@eugenetriguba
eugenetriguba requested a review from rhettinger as a code owner May 21, 2024 12:46
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2024
@eugenetriguba
Merge branch 'main' into gh-119306
fb00791
@eugenetriguba eugenetriguba changed the title Break up _pyrepl tests gh-119306: Break up _pyrepl tests May 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
Break up _pyrepl tests #119306
Closed
@eugenetriguba

eugenetriguba commented May 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I think this PR doesn't need a news entry. Let me know if these changes make sense
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eugenetriguba added 7 commits May 21, 2024 08:54
@eugenetriguba
Merge branch 'main' into gh-119306
fcba959
@eugenetriguba
Fix lint for end of file
a501977
@eugenetriguba
Fix mypy
82c6ecf
@eugenetriguba
Remove import
a3ae59f
@eugenetriguba
Merge branch 'main' into gh-119306
2e02764
@eugenetriguba
Fix makefile test
c82fc14
@eugenetriguba
Merge branch 'main' into gh-119306
dfadf14
@rhettinger
rhettinger removed their request for review May 21, 2024 15:46
@ambv ambv added the skip news label May 21, 2024
@ambv
ambv merged commit f49df4f into python:main May 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 21, 2024
@lysnikolaou lysnikolaou added needs backport to 3.13 only security fixes topic-repl Related to the interactive shell labels May 21, 2024
@miss-islington-app

miss-islington-app Bot commented May 21, 2024

Copy link
Copy Markdown

Thanks @eugenetriguba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 21, 2024

Copy link
Copy Markdown

Sorry, @eugenetriguba and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f49df4f486e531ff2666eb22854117c564b3de3d 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned ambv May 21, 2024
lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull request May 21, 2024
@eugenetriguba @lysnikolaou
[3.13] pythongh-119306: Break up _pyrepl tests (pythonGH-119307)
47ac2b0 
(cherry picked from commit f49df4f)

Co-authored-by: Eugene Triguba <[email protected]>
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119362 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 21, 2024
lysnikolaou added a commit that referenced this pull request May 22, 2024
@lysnikolaou @eugenetriguba
[3.13] gh-119306: Break up _pyrepl tests (GH-119307) (#119362)
7214598 
(cherry picked from commit f49df4f)

Co-authored-by: Eugene Triguba <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@eugenetriguba @estyxx
pythongh-119306: Break up _pyrepl tests (python#119307)
ecfa484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eugenetriguba @ambv @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.