GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fix missing atomic in dict_resize by DinoV · Pull Request #119312 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use atomic to assign to PyDictValues->valid like we do elsewhere

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
Fix missing atomic in dict_resize
903c21a
@DinoV
DinoV requested review from markshannon and methane as code owners May 21, 2024 14:44
@bedevere-app bedevere-app Bot added the awaiting core review label May 21, 2024
@DinoV
DinoV requested review from colesbury and removed request for markshannon and methane May 21, 2024 14:44
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@DinoV DinoV added topic-free-threading skip news labels May 21, 2024
colesbury
colesbury approved these changes May 21, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport this to 3.13

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DinoV reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 21, 2024
@DinoV DinoV added the needs backport to 3.13 only security fixes label May 22, 2024
@DinoV

DinoV commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

We should backport this to 3.13

Backport to 3.13: #119416
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DinoV
DinoV merged commit 2b3fb76 into python:main May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 22, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@DinoV @miss-islington
pythongh-117657: Fix missing atomic in dict_resize (pythonGH-119312)
95b016a 
Fix missing atomic in dict_resize
(cherry picked from commit 2b3fb76)

Co-authored-by: Dino Viehland <[email protected]>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119417 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 22, 2024
DinoV added a commit that referenced this pull request May 22, 2024
@miss-islington @DinoV
[3.13] gh-117657: Fix missing atomic in dict_resize (GH-119312) (#119417
cd35e9d 
)

gh-117657: Fix missing atomic in dict_resize (GH-119312)

Fix missing atomic in dict_resize
(cherry picked from commit 2b3fb76)

Co-authored-by: Dino Viehland <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@DinoV
DinoV deleted the nogil_dict_resize branch May 31, 2024 18:21
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@DinoV @estyxx
pythongh-117657: Fix missing atomic in dict_resize (python#119312)
6c5ee0d 
Fix missing atomic in dict_resize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.