GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119317: findall instead of traverse for docutils nodes by drts01 · Pull Request #119319 · python/cpython

Conversation

@drts01

@drts01 drts01 commented May 21, 2024 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The new method, findall, is a generator rather than returning a list.

closes #119317

  • Issue: Resolve deprecation warnings in Docs/tools #119317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
Resolve deprecation warnings in Docs/tools #119317
Closed
@drts01
findall instead of traverse for docutils nodes
3830593 
closes python#119317
@drts01
drts01 force-pushed the fix_docs_tools_deprecation_warnings_119317 branch from 2312026 to 3830593 Compare May 21, 2024 16:11
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willingc willingc added docs Documentation in the Doc dir skip news labels May 21, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 24, 2024
@hugovk

hugovk commented May 24, 2024

Copy link
Copy Markdown
Member

Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 0867bce into python:main May 24, 2024
@miss-islington-app

miss-islington-app Bot commented May 24, 2024

Copy link
Copy Markdown

Thanks @xsc27 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label May 24, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@drts01 @miss-islington
pythongh-119317: findall instead of traverse for docutils nodes (pyth…
09b3794 
…onGH-119319)

(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <[email protected]>
@bedevere-app

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119486 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@drts01 @miss-islington
pythongh-119317: findall instead of traverse for docutils nodes (pyth…
dd7d926 
…onGH-119319)

(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 24, 2024
@bedevere-app

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119487 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 24, 2024
hugovk pushed a commit that referenced this pull request May 24, 2024
@miss-islington @drts01
[3.12] gh-119317: findall instead of traverse for docutils nodes (GH-…
2b091b9 
…119319) (#119487)

gh-119317: findall instead of traverse for docutils nodes (GH-119319)
(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <[email protected]>
hugovk pushed a commit that referenced this pull request May 27, 2024
@miss-islington @drts01
[3.13] gh-119317: findall instead of traverse for docutils nodes (GH-…
7322ff1 
…119319) (#119486)

gh-119317: findall instead of traverse for docutils nodes (GH-119319)
(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@drts01 @estyxx
pythongh-119317: findall instead of traverse for docutils nodes (pyth…
94e2e3e 
…on#119319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resolve deprecation warnings in Docs/tools

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@drts01 @hugovk @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.