GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119102: Fix REPL for dumb terminal by vstinner · Pull Request #119332 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The site module gets the main module to get _pyrepl.main.

  • Issue: New pyrepl gives a traceback on exit with "dumb" terminal #119102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-119102: Fix REPL for dumb terminal
b2549d1 
The site module gets the __main__ module to get _pyrepl.__main__.
@vstinner vstinner added the needs backport to 3.13 only security fixes label May 21, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
New pyrepl gives a traceback on exit with "dumb" terminal #119102
Closed
@vstinner vstinner mentioned this pull request May 21, 2024
gh-119102: Fix REPL for dumb terminal #119269
Merged
lysnikolaou
lysnikolaou reviewed May 21, 2024
View reviewed changes
Comment thread Lib/site.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Use False on ImportError
eb4b00a
@lysnikolaou lysnikolaou added skip news topic-repl Related to the interactive shell labels May 21, 2024
lysnikolaou
lysnikolaou approved these changes May 21, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 21, 2024
@eugenetriguba

eugenetriguba commented May 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@vstinner I took a crack at it here when I noticed the first PR that had the mypy fix reverted the bug fix: #119328. Do you have a preference of approach? Happy to close that one out or try to get that test properly working in that PR and just try to get that merged in instead 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielhollas
danielhollas approved these changes May 21, 2024
View reviewed changes

@danielhollas danielhollas left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner enabled auto-merge (squash) May 21, 2024 18:55
@vstinner

vstinner commented May 21, 2024

Copy link
Copy Markdown
Member Author

Thanks for the review and testing!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit de8f530 into python:main May 21, 2024
@vstinner
vstinner deleted the pyrepl_dumb2 branch May 21, 2024 20:33
@miss-islington-app

miss-islington-app Bot commented May 21, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@vstinner @miss-islington
pythongh-119102: Fix REPL for dumb terminal (pythonGH-119332)
bb5c037 
The site module gets the __main__ module to get _pyrepl.__main__.
(cherry picked from commit de8f530)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

GH-119359 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 21, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
@miss-islington @vstinner
[3.13] gh-119102: Fix REPL for dumb terminal (GH-119332) (#119359)
f371565 
The site module gets the __main__ module to get _pyrepl.__main__.
(cherry picked from commit de8f530)

Co-authored-by: Victor Stinner <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119102: Fix REPL for dumb terminal (python#119332)
d25ceee 
The site module gets the __main__ module to get _pyrepl.__main__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes
+1 more reviewer
@danielhollas danielhollas danielhollas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @eugenetriguba @danielhollas @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.