GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111201: Speed up paste mode in the REPL by pablogsal · Pull Request #119341 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: A new Python REPL #111201

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from lysnikolaou May 21, 2024 18:53
@bedevere-app bedevere-app Bot added the awaiting core review label May 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
A new Python REPL #111201
Closed
7 tasks done
@pablogsal

pablogsal commented May 21, 2024

Copy link
Copy Markdown
Member Author

This depends on #119318 landing first
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the topic-repl Related to the interactive shell label May 21, 2024
@ambv ambv added the skip news label May 21, 2024
@pablogsal
pythongh-111201: Speed up paste mode in the REPL
fe028c9
@pablogsal
pablogsal force-pushed the speed branch from cef4312 to fe028c9 Compare May 21, 2024 20:05
ambv added 3 commits May 21, 2024 22:38
@ambv
Fix Pablo's linting mishap
696d85d
@ambv
Merge branch 'main' into pythongh-119341
4ba82b2
@ambv
close but no cigar
dc81f20
@ambv
ambv merged commit e6572e8 into python:main May 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 22, 2024
@lysnikolaou

lysnikolaou commented May 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I think that this has broken paste. Pasting code shows the last character of the pasted line only. The whole buffer is shown after hitting backspace. If arrows are used between the paste and the backspace, the buffer gets completely messed up.

cc @ambv @pablogsal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 22, 2024

Copy link
Copy Markdown
Member Author

Hummm, we live tested this several times. I wonder if there is some weird interaction with other PRs we landed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 22, 2024

Copy link
Copy Markdown
Member Author

We should revert meanwhile I think
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 22, 2024

Copy link
Copy Markdown
Member Author

@lysnikolaou @ambv WDYT?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented May 22, 2024

Copy link
Copy Markdown
Member

+1 for reverting, otherwise it might be hard to do manual testing of PRs at the sprints.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented May 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#119432 fixes this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lysnikolaou pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@pablogsal @ambv @lysnikolaou
pythongh-111201: Speed up paste mode in the REPL (python#119341)
1909b7b 
Co-authored-by: Łukasz Langa <[email protected]>
lysnikolaou added a commit that referenced this pull request May 23, 2024
@miss-islington @pablogsal
@ambv @lysnikolaou
[3.13] gh-111201: Speed up paste mode in the REPL (#119341) (GH-119432)…
58dbb4a 
… (#119439)

(cherry picked from commit e6572e8)

Also includes:

* gh-111201: Use calc_complete_screen after bracketed paste in PyREPL (GH-119432)
(cherry picked from commit 14b063c)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
@pablogsal
pablogsal deleted the speed branch May 23, 2024 12:18
@treyhunner treyhunner mentioned this pull request May 24, 2024
Odd behavior from pasting large text in the new REPL #119517
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal @ambv @estyxx
pythongh-111201: Speed up paste mode in the REPL (python#119341)
3079f8d 
Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @lysnikolaou @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.