GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: set correct working directory for Hypothesis cache by Zac-HD · Pull Request #119345 · python/cpython

Conversation

@Zac-HD

@Zac-HD Zac-HD commented May 21, 2024

Copy link
Copy Markdown
Contributor

I noticed when pairing with @encukou that this cache logic never found any files to upload (nor restore).

This isn't a huge problem, but ensuring that we replay any known failing examples on your branch is a nicer developer experience, made possible by persisting the cache between runs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zac-HD
Zac-HD requested review from ezio-melotti and hugovk as code owners May 21, 2024 19:20
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2024
@Zac-HD Zac-HD mentioned this pull request May 22, 2024
[Meta] Research: what can we test with Hypothesis? #107862
Open
encukou
encukou previously approved these changes May 22, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 22, 2024
@encukou encukou added skip issue skip news labels May 22, 2024
@encukou
encukou enabled auto-merge (squash) May 22, 2024 14:30
auto-merge was automatically disabled May 22, 2024 16:33

Head branch was pushed to by a user without write access

@Zac-HD
Zac-HD force-pushed the zac/fix-hypothesis-ci-caching branch from 791c418 to 219de60 Compare May 22, 2024 16:33
@Zac-HD
Zac-HD marked this pull request as draft May 22, 2024 16:54
@bedevere-app bedevere-app Bot removed the awaiting merge label May 22, 2024
@Zac-HD

Zac-HD commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

Marking as draft; I'll mark ready-for-review once I see a build which successfully uploaded the cache and artifact.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented May 22, 2024

Copy link
Copy Markdown
Member

GitHub might be using the main branch's actions rather than those from this PR.
One workaround is to enable actions on your fork, and open a PR against that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Zac-HD
Zac-HD force-pushed the zac/fix-hypothesis-ci-caching branch from 219de60 to 3a51825 Compare May 23, 2024 18:56
@encukou
encukou dismissed their stale review May 23, 2024 19:23

Experiments are going on

@bedevere-app bedevere-app Bot added the awaiting review label May 23, 2024
@Zac-HD
Set cwd for Hypothesis database
dbfb2e6
@Zac-HD
Zac-HD force-pushed the zac/fix-hypothesis-ci-caching branch from 083f0eb to dbfb2e6 Compare May 26, 2024 22:24
@Zac-HD
Zac-HD marked this pull request as ready for review May 26, 2024 22:33
@Zac-HD

Zac-HD commented May 26, 2024

Copy link
Copy Markdown
Contributor Author

@encukou got it! The problem was that Regrtest switches to a tempdir, so I also needed to configure Hypothesis to use the original working dir for the database. With that in place, the cache is working and the artifact upload is (correctly) skipped when no tests failed.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented May 29, 2024

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 055c739 into python:main May 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 29, 2024
@Zac-HD
Zac-HD deleted the zac/fix-hypothesis-ci-caching branch May 29, 2024 15:57
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Zac-HD @estyxx
CI: set correct working directory for Hypothesis cache (pythonGH-119345)
8a295d0 
Set cwd for Hypothesis database
@sobolevn sobolevn added the needs backport to 3.13 only security fixes label Apr 10, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 10, 2025

Copy link
Copy Markdown

Thanks @Zac-HD for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2025
@Zac-HD @miss-islington
CI: set correct working directory for Hypothesis cache (pythonGH-119345)
09a7e32 
Set cwd for Hypothesis database
(cherry picked from commit 055c739)

Co-authored-by: Zac Hatfield-Dodds <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 10, 2025

Copy link
Copy Markdown

GH-132364 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 10, 2025
@sobolevn

sobolevn commented Apr 10, 2025

Copy link
Copy Markdown
Member

See #132348 on why we backport this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn pushed a commit that referenced this pull request Apr 10, 2025
@miss-islington @Zac-HD
[3.13] CI: set correct working directory for Hypothesis cache (GH-119345
ce92107 
) (#132364)

CI: set correct working directory for Hypothesis cache (GH-119345)

Set cwd for Hypothesis database
(cherry picked from commit 055c739)

Co-authored-by: Zac Hatfield-Dodds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Zac-HD @encukou @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.