GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119357: Increase test coverage for keymap in _pyrepl by eugenetriguba · Pull Request #119358 · python/cpython

Conversation

@eugenetriguba

@eugenetriguba eugenetriguba commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR adds a few test cases to the keymap module tests to increase the coverage.

Lib/_pyrepl/keymap.py                 79      0     48      0   100%
  • Issue: Increase coverage of test_pyrepl #119357

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eugenetriguba
Increase test coverage for keymap in _pyrepl
7623575
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
Increase coverage of test_pyrepl #119357
Closed
eugenetriguba
eugenetriguba commented May 21, 2024
View reviewed changes
Comment thread Lib/_pyrepl/completing_reader.py
# types
Command = commands.Command
if False:
from .types import Callback, SimpleContextManager, KeySpec, CommandName

@eugenetriguba eugenetriguba May 21, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: these two aren't used

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eugenetriguba
Merge branch 'main' into gh-119357
45e01c2
@eugenetriguba

eugenetriguba commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

I'd think this PR can skip news
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv added skip news topic-repl Related to the interactive shell labels May 21, 2024
ambv
ambv reviewed May 21, 2024
View reviewed changes
Comment thread Lib/_pyrepl/keymap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv
Fix mypy
6986565
@eugenetriguba

eugenetriguba commented May 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@ambv beat me to it, thanks for the fix 🙂 I'll update the issue to more clearly encompass all of PyREPL instead of just the keymap module. Thanks for the feedback, let me know if you had any other requested changes!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eugenetriguba
Merge branch 'main' into gh-119357
10a06f0
@ambv
ambv merged commit 73ab83b into python:main May 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 22, 2024
@lysnikolaou lysnikolaou added the needs backport to 3.13 only security fixes label May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @eugenetriguba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Sorry, @eugenetriguba and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 73ab83b27f105a4509046ce26e35f20d66625195 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned ambv May 22, 2024
lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull request May 22, 2024
@eugenetriguba @ambv @lysnikolaou
[3.13] pythongh-119357: Increase test coverage for keymap in _pyrepl (p…
f509295 
…ythonGH-119358)

(cherry picked from commit 73ab83b)

Co-authored-by: Eugene Triguba <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119414 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 22, 2024
ambv added a commit that referenced this pull request May 22, 2024
@lysnikolaou @eugenetriguba @ambv
[3.13] gh-119357: Increase test coverage for keymap in _pyrepl (GH-11…
e6e4efc 
…9358) (#119414)

(cherry picked from commit 73ab83b)

Co-authored-by: Eugene Triguba <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@eugenetriguba @ambv @estyxx
pythongh-119357: Increase test coverage for keymap in _pyrepl (python…
78a44a9 
…#119358)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eugenetriguba @ambv @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.