GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119336: Restore _PyLong_NumBits by emmatyping · Pull Request #119418 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented May 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is used in pywin32, and the function being moved to internal headers broke with 3.13. Restore it for now to eventually be considered for being made a public symbol.

See also #112026 (previous restoration) and #111481 (public replacements)

This should be backported to 3.13 if accepted.

  • Issue: '_PyLong_NumBits': identifier not found in 3.13 #119336

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Avasam reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@emmatyping
Restore removed _PyLong_NumBits
1dec5bf
@bedevere-app bedevere-app Bot added the awaiting review label May 22, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 22, 2024
'_PyLong_NumBits': identifier not found in 3.13 #119336
Closed
emmatyping and others added 2 commits May 22, 2024 10:45
@emmatyping
Merge branch 'main' into replace_pylong_numbits
04f404a
@blurb-it
📜🤖 Added by blurb_it.
9c161b8
@Avasam Avasam mentioned this pull request May 28, 2024
3.13 support mhammond/pywin32#2260
Merged
@encukou
encukou requested a review from vstinner May 28, 2024 14:30
@vstinner

vstinner commented May 28, 2024

Copy link
Copy Markdown
Member

I'm not convinced that we have to revert this function: #119336 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed May 29, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/C API/2024-05-22-17-50-48.gh-issue-119336.ff3qnS.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Update Misc/NEWS.d/next/C API/2024-05-22-17-50-48.gh-issue-119336.ff3…
08d0036 
…qnS.rst
vstinner
vstinner approved these changes May 29, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 29, 2024
@vstinner
vstinner enabled auto-merge (squash) May 29, 2024 09:32
@vstinner vstinner mentioned this pull request May 29, 2024
[C API] Add PyLong_GetNumBits() function #119714
Closed
@vstinner
vstinner merged commit e50fac9 into python:main May 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 30, 2024
@vstinner vstinner added the needs backport to 3.13 only security fixes label Jun 3, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

Thanks @ethanhs for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
@emmatyping @miss-islington
pythongh-119336: Restore removed _PyLong_NumBits() function (pythonGH…
bf67508 
…-119418)

It is used by the pywin32 project.
(cherry picked from commit e50fac9)

Co-authored-by: Ethan Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

GH-119970 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 3, 2024
vstinner pushed a commit that referenced this pull request Jun 3, 2024
@miss-islington @emmatyping
[3.13] gh-119336: Restore removed _PyLong_NumBits() function (GH-119418…
cc663b7 
…) (#119970)

gh-119336: Restore removed _PyLong_NumBits() function (GH-119418)

It is used by the pywin32 project.
(cherry picked from commit e50fac9)

Co-authored-by: Ethan Smith <[email protected]>
@emmatyping
emmatyping deleted the replace_pylong_numbits branch June 11, 2024 20:34
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@emmatyping @estyxx
pythongh-119336: Restore removed _PyLong_NumBits() function (python#1…
468b614 
…19418)

It is used by the pywin32 project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@emmatyping @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.