GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119434: Fix culmitive errors in wrapping as lines proceed by DinoV · Pull Request #119435 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented May 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The new REPL has an issue when outputting at the right edge of the console window. It tries to output a "" at the end, and then print the typed character at the beginning of the next line. This works fine on the first line. The 2nd line the "" + char doesn't show up until after you press a 2nd char. And at the 3rd line it takes 3 chars, and so on.

  • Issue: REPL takes extra key presses on long inputs that wrap around lines #119434

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
Fix culmitive errors in wrapping as lines proceed
d793f36
@bedevere-app bedevere-app Bot added the awaiting core review label May 22, 2024
@DinoV
DinoV requested a review from pablogsal May 22, 2024 20:02
@bedevere-app bedevere-app Bot mentioned this pull request May 22, 2024
REPL takes extra key presses on long inputs that wrap around lines #119434
Closed
@DinoV
DinoV requested review from ambv and lysnikolaou May 22, 2024 20:03
@DinoV DinoV added skip news topic-repl Related to the interactive shell labels May 22, 2024
pablogsal
pablogsal approved these changes May 22, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 22, 2024
@DinoV DinoV added the needs backport to 3.13 only security fixes label May 22, 2024
@DinoV
DinoV merged commit e3bf538 into python:main May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 22, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@DinoV @miss-islington
pythongh-119434: Fix culmitive errors in wrapping as lines proceed (p…
a6c9822 
…ythonGH-119435)

Fix culmitive errors in wrapping as lines proceed
(cherry picked from commit e3bf538)

Co-authored-by: Dino Viehland <[email protected]>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119441 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 22, 2024
lysnikolaou pushed a commit that referenced this pull request May 23, 2024
@miss-islington @DinoV
[3.13] gh-119434: Fix culmitive errors in wrapping as lines proceed (G…
dbff1f1 
…H-119435) (#119441)

Fix culmitive errors in wrapping as lines proceed
(cherry picked from commit e3bf538)

Co-authored-by: Dino Viehland <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@DinoV
DinoV deleted the repl_wrap branch May 31, 2024 18:24
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@DinoV @estyxx
pythongh-119434: Fix culmitive errors in wrapping as lines proceed (p…
d956dc7 
…ython#119435)

Fix culmitive errors in wrapping as lines proceed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.