GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix typos in HISTORY documentation by xyb · Pull Request #119453 · python/cpython

Conversation

xyb commented May 23, 2024

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

xyb added 2 commits

May 23, 2024 16:25


          Fix typos in HISTORY documentation

8a34325


          add Xie Yanbo to ACKS

1015b93

bedevere-app Bot added the awaiting review label

May 23, 2024

blaisep approved these changes

May 24, 2024

View reviewed changes

blaisep left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xyb , thank you very much for these corrections, they look very good. I will ask @CAM-Gerlach to consider merging this PR because it looks clean.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting core review and removed awaiting review labels

May 24, 2024

blaisep commented May 24, 2024

Copy link

Copy Markdown

Contributor

@CAM-Gerlach , this PR will need labels for skip-issue (and maybe skip-news). I don't think I can add those labels myself.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

xyb commented May 27, 2024

Copy link

Copy Markdown

Contributor Author

@CAM-Gerlach @hauntsaninja @serhiy-storchaka @AlexWaygood Please take a look, thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added skip issue skip news needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

May 27, 2024

hugovk merged commit 5ef5622 into python:main

May 27, 2024

miss-islington-app Bot commented May 27, 2024

Copy link

Copy Markdown

Thanks @xyb for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

May 27, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 27, 2024


          Fix typos in HISTORY documentation (pythonGH-119453)

e42ed30

(cherry picked from commit 5ef5622)

Co-authored-by: Xie Yanbo <[email protected]>

bedevere-app Bot commented May 27, 2024

Copy link

Copy Markdown

GH-119597 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 27, 2024


          Fix typos in HISTORY documentation (pythonGH-119453)

bc51c43

(cherry picked from commit 5ef5622)

Co-authored-by: Xie Yanbo <[email protected]>

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

May 27, 2024

bedevere-app Bot commented May 27, 2024

Copy link

Copy Markdown

GH-119598 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

May 27, 2024

hugovk commented May 27, 2024

Copy link

Copy Markdown

Member

@CAM-Gerlach @hauntsaninja @serhiy-storchaka @AlexWaygood Please take a look, thank you!

Thanks for the PR, but no need to ping four core devs about it 👍

AlexWaygood reacted with thumbs up emoji

xyb reacted with heart emoji

All reactions

👍 1 reaction
❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

xyb deleted the fixtypos branch

May 27, 2024 08:02

hugovk pushed a commit that referenced this pull request

May 27, 2024


          [3.12] Fix typos in HISTORY documentation (GH-119453) (#119598)

53843c2

Co-authored-by: Xie Yanbo <[email protected]>

hugovk pushed a commit that referenced this pull request

May 27, 2024


          [3.13] Fix typos in HISTORY documentation (GH-119453) (#119597)

46d7712

Co-authored-by: Xie Yanbo <[email protected]>

JelleZijlstra mentioned this pull request

May 28, 2024

backport a9a74da 3.13 #119642

Closed

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024


          Fix typos in HISTORY documentation (python#119453)

Reviewers

1 more reviewer

blaisep

blaisep approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.