GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119535: python𝜋 by hauntsaninja · Pull Request #119536 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented May 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Support pythonπ in Python 3.14 venv's #119535

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

devdanzin, dolfinus, and jbosboom reacted with thumbs down emoji danielhollas, Eclips4, emmatyping, nineteendo, dzhalaevd, wallseat, magistau, tpvasconcelos, agriyakhetarpal, Alpha-Qian, and 7 more reacted with laugh emoji AlexWaygood, wallseat, magistau, MartinCura, agriyakhetarpal, Lemminkyinen, and webknjaz reacted with rocket emoji
All reactions
  • 👎 3 reactions
  • 😄 17 reactions
  • 🚀 7 reactions
@hauntsaninja
pythongh-119535: pythonπ
02c08dc
@hauntsaninja
hauntsaninja requested a review from vsajip as a code owner May 25, 2024 06:18
@bedevere-app bedevere-app Bot added the awaiting core review label May 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2024
Support pythonπ in Python 3.14 venv's #119535
Closed
@blurb-it
📜🤖 Added by blurb_it.
d9d70db
@hauntsaninja
hauntsaninja requested a review from hugovk May 25, 2024 06:20
@hauntsaninja
fix markup
6e97c87
rruuaanng
rruuaanng reviewed Oct 5, 2024
View reviewed changes
Comment thread Lib/venv/__init__.py Outdated

suffixes = ['python', 'python3', f'python3.{sys.version_info[1]}']
if sys.version_info[:2] == (3, 14):
suffixes.append('pythonπ')

@rruuaanng rruuaanng Oct 5, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using python-pi or python_pi would be better. I think using special characters may cause garbled characters on some platform.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@hauntsaninja hauntsaninja Oct 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what platform / filesystem are you concerned about, and what would the impact to the user on that platform be? (note in this branch we know os.name == "posix")

A Greek letter isn't really that special. It's fully normalised Unicode (non-normalised Unicode can still be a little surprising). Looks like even FAT has supported this since around the time I was born via LFN.

See also https://peps.python.org/pep-0011/#legacy-c-locale part of PEP 11

This is decidedly one of the advantages of being alive in 2024 :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@skirpichev skirpichev Oct 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux console with no framebuffer?

Console fonts without this glyph? I sometimes do math with the Diofant in the framebuffer console (yes, it has unicode support). I works well with greek letters, do some pretty-printing to display formulas. But I doubt it's able to display e.g. chinese texts an non-garbadge. (Perhaps, with other font, which I don't have...)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@hauntsaninja hauntsaninja Oct 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC https://wiki.archlinux.org/title/Linux_console says that the Linux console uses UTF-8, but we may indeed have to worry about whether the console font is missing π. The same page says the kernel built-in font can render the CP437 character set, which does have π (and dates back to the original IBM PC).

It's possible I misunderstood something, but even the case where the font is missing the glyph, is the worst thing that can happen that a user will see an unrendered glyph if ls-ing? That doesn't seem that bad, and sounds in line with the vibes of what PEP 11 describes as "won't fix". (And of course, if users report problems during prerelease we can revert)

Edit: note the CP437 stuff probably doesn't apply to U+1d70b which the PR has been updated to use. It might also have worse font support

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@ncoghlan ncoghlan Oct 6, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminals cope with missing glyphs already (usually by rendering an ASCII ?, or a dedicated replacement character).

If the active encoding is sufficiently wrong, they don't even see the raw unicode:

$ ls -d _[bd]*
_build🐸  _deploy🐸
$ LANG=C ls -d _[bd]*
'_build'$'\360\237\220\270'  '_deploy'$'\360\237\220\270'

So yeah, as far as easter eggs go, this one is as close to genuinely harmless as they get.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
skirpichev
skirpichev reviewed Oct 5, 2024
View reviewed changes
Comment thread Lib/venv/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk reviewed Oct 5, 2024
View reviewed changes
Comment thread Lib/venv/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood
AlexWaygood approved these changes Oct 5, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Easter eggs are fun, and I can't see any serious harm in doing this, because I seriously doubt anybody will use it for any serious use :-)

I don't have a strong opinion on https://github.com/python/cpython/pull/119536/files#r1788711396.

Sad that the Windows users won't get the Easter egg! (But I don't think that should block merging this 😆)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

buffmomoeveryday reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 5, 2024
picnixz
picnixz reviewed Oct 5, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-05-25-06-19-46.gh-issue-119535.RXmed8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner
AA-Turner approved these changes Oct 5, 2024
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex took all I wanted to say!

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Misc/NEWS.d/next/Library/2024-05-25-06-19-46.gh-issue-119535.RXmed8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan
ncoghlan reviewed Oct 6, 2024
View reviewed changes
Comment thread Lib/venv/__init__.py Outdated

suffixes = ['python', 'python3', f'python3.{sys.version_info[1]}']
if sys.version_info[:2] == (3, 14):
suffixes.append('pythonπ')

@ncoghlan ncoghlan Oct 6, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @ambv , this should use the mathematical symbol variant of 𝜋, rather than the Greek letter variant:

Suggested change
suffixes.append('pythonπ')
suffixes.append('python𝜋')

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk, nineteendo, and AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

@hugovk hugovk Oct 6, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hauntsaninja Let's include this, remove the NEWS, and keep the version check. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@hauntsaninja hauntsaninja Oct 6, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made the updates!

(Note that U+1d70b isn't NFKC normalised. I know in some cases non-normalised Unicode can cause issues in filesystems, but I think that's usually about NFC/NFD normalisation)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hauntsaninja hauntsaninja added the skip news label Oct 6, 2024
hauntsaninja added 2 commits October 6, 2024 11:03
@hauntsaninja
use 1d70b
1a413cd
@hauntsaninja
remove news
d0f8f83
@nineteendo

nineteendo commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

Can you update the title of the PR?

AlexWaygood reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood AlexWaygood changed the title gh-119535: pythonπ gh-119535: python𝜋 Oct 6, 2024
hugovk
hugovk approved these changes Oct 6, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, everyone: shhh!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan, danielhollas, emmatyping-nv, adamchainz, agriyakhetarpal, grindarius, JotaRata, helloworld3200, devilmanz, Zethson, and iglebov reacted with laugh emoji MartinCura reacted with hooray emoji AlexWaygood, MartinCura, swivelmargarita, and johnzhou721 reacted with rocket emoji
All reactions
  • 😄 11 reactions
  • 🎉 1 reaction
  • 🚀 4 reactions
@hugovk
hugovk merged commit 3fc673e into python:main Oct 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 6, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request May 15, 2025
@hugovk
Revert "pythongh-119535: python𝜋 (python#119536)"
6594616
This reverts commit 3fc673e.
hauntsaninja pushed a commit that referenced this pull request May 15, 2025
@hugovk
gh-119535: 3.15 minus π (#134037)
54a6875
* Revert "gh-119535: Support 𝜋thon in Python 3.14 venvs (#125035)"

This reverts commit fcef3fc.

* Revert "gh-119535: python𝜋 (#119536)"

This reverts commit 3fc673e.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hugovk @Pranjal095
pythongh-119535: 3.15 minus π (python#134037)
ea4dd2f
* Revert "pythongh-119535: Support 𝜋thon in Python 3.14 venvs (python#125035)"

This reverts commit fcef3fc.

* Revert "pythongh-119535: python𝜋 (python#119536)"

This reverts commit 3fc673e.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hugovk @taegyunkim
pythongh-119535: 3.15 minus π (python#134037)
ff98243
* Revert "pythongh-119535: Support 𝜋thon in Python 3.14 venvs (python#125035)"

This reverts commit fcef3fc.

* Revert "pythongh-119535: python𝜋 (python#119536)"

This reverts commit 3fc673e.
This was referenced Jun 15, 2026
Support π and 𝜋 in Pyodide venv launchers for Pyodide 314.x xbuildenvs pyodide/pyodide-build#387
Closed
Support π and 𝜋 in Pyodide venv launchers for Pyodide 314.x xbuildenvs pyodide/pyodide-build#388
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments
@skirpichev skirpichev skirpichev left review comments
@picnixz picnixz picnixz left review comments
@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
+2 more reviewers
@nineteendo nineteendo nineteendo left review comments
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@hauntsaninja @nineteendo @ncoghlan @hugovk @skirpichev @AA-Turner @picnixz @AlexWaygood @rruuaanng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.