GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update README and layout.html from 3.13 to 3.14 by Wulian233 · Pull Request #119539 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Skip issue and news


📚 Documentation preview 📚: https://cpython-previews--119539.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo and Wulian233 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
Wulian233 and others added 6 commits May 23, 2024 20:07
@Wulian233
Fix high DPI causes Tools/unittestgui(PyUnit) window blurry on Windows
5e5f1a3
@Wulian233
lint
ab9781a
@Wulian233
Merge branch 'python:main' into main
bcce855
@Wulian233
Update README.rst
570dc55
@Wulian233
Update layout.html
d7651de
@Wulian233
Update help.html
d46ec13
@Wulian233
Wulian233 requested a review from terryjreedy as a code owner May 25, 2024 10:35
@bedevere-app bedevere-app Bot added the awaiting review label May 25, 2024
@Wulian233

Wulian233 commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Oh NO. There was an accident, my last not merge PR changed files was added here
﹉
I was revert it, unittestgui.py looks no change, but show in file changed list

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Wulian233 and others added 4 commits May 25, 2024 18:38
@Wulian233
Delete my last PR files
8b6477c
@Wulian233
?
2265fa9
@Wulian233
Merge branch 'readme' of https://github.com/Wulian233/cpython into re…
aaf0067
…adme
@Wulian233
revert
e69e8f8
@nineteendo

nineteendo commented May 25, 2024

Copy link
Copy Markdown
Contributor

I think we can add skip issue and news.

Wulian233 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233

Wulian233 commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'm not sure layout.html should keep 3.13(dev), I deleted (dev) to 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo
nineteendo reviewed May 25, 2024
View reviewed changes
Comment thread Doc/tools/templates/layout.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233 @nineteendo
Update Doc/tools/templates/layout.html
fe0ed7f
Co-authored-by: Nice Zombies <[email protected]>
@Eclips4 Eclips4 added skip issue skip news labels May 25, 2024
@Wulian233 Wulian233 mentioned this pull request May 25, 2024
Docs: Move inline JavaScript to own file to reduce duplication #119541
Merged
@Wulian233

Wulian233 commented May 25, 2024

Copy link
Copy Markdown
Contributor Author

See #119541
layout.html -> js
Do the layout.html changes here need cancel? Add 3.14 in the #119541 ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nineteendo

nineteendo commented May 25, 2024

Copy link
Copy Markdown
Contributor

You can wait to see which pull request is merged first.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented May 25, 2024

Copy link
Copy Markdown
Member

unittestgui.py looks no change, but show in file changed list

Please delete unittestgui.py from the PR, or I can do it for you if you like?

See #119541 layout.html -> js
Do the layout.html changes here need cancel?
Add 3.14 in the #119541 ?

It makes more sense to add 3.14 to layout.html here, so #119541 is just moving code, not adding to it. We can resolve conflicts later.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233

Wulian233 commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

unittestgui.py looks no change, but show in file changed list

Please delete unittestgui.py from the PR, or I can do it for you if you like?

Can you help me delete the unittestgui.py, thx☺️

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
Re-add +x permissions
52751a0
@hugovk

hugovk commented May 25, 2024

Copy link
Copy Markdown
Member

Done, or rather what was needed was to re-add the x permission.

nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nineteendo

nineteendo commented May 25, 2024

Copy link
Copy Markdown
Contributor

Ah wow, '100644' -> '100755' is the change in the mode of the file.
Wouldn't '-rw-r--r--' -> '-rwxr-xr-x' be more readable?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy

terryjreedy commented May 25, 2024

Copy link
Copy Markdown
Member

Remove idlelib/help.html from this PR. The change is wrong. I presume you can just revert the corresponding commit.

I believe your DPI commit was included because you made the change to main rather than a dpi branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy terryjreedy added the DO-NOT-MERGE label May 25, 2024
@Wulian233
update help.html
e42606b
@Wulian233
update help.html
673a2ff
@Wulian233

Wulian233 commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Yes I made the change to main instead dpi branch:( and I have revert the help.html

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy terryjreedy removed the DO-NOT-MERGE label May 26, 2024
@terryjreedy

terryjreedy commented May 26, 2024

Copy link
Copy Markdown
Member

@hugovk Can you either handle this or ping someone else?

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk reviewed May 26, 2024
View reviewed changes
Comment thread README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233 @hugovk
Update README.rst
33e4fd4
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk reviewed May 26, 2024
View reviewed changes
Comment thread README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk changed the title Update Readme and others from 3.13 to 3.14 Update README and layout.html from 3.13 to 3.14 May 26, 2024
@Wulian233 @hugovk
Update README.rst
25489a9
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk approved these changes May 26, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 26, 2024
@hugovk
hugovk enabled auto-merge (squash) May 26, 2024 11:24
@hugovk
hugovk merged commit b5b7dc9 into python:main May 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 26, 2024
@hugovk hugovk mentioned this pull request May 27, 2024
[3.13] Docs: Move inline JavaScript to own file to reduce duplication (GH-119541) #119630
Merged
@nineteendo nineteendo mentioned this pull request Jun 14, 2024
Add test to verify idlelib/help.html is in sync with docs #120360
Open
@Wulian233
Wulian233 deleted the readme branch July 2, 2024 13:41
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Wulian233 @nineteendo
@hugovk @estyxx
Update README and layout.html from 3.13 to 3.14 (python#119539)
201079f
Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@Wulian233 Wulian233 mentioned this pull request May 25, 2025
Update README.rst informations from 3.14 to 3.15 #134649
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
+1 more reviewer
@nineteendo nineteendo nineteendo left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Wulian233 @nineteendo @hugovk @terryjreedy @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.