GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102864: Add switching frame test for pdb by gaogaotiantian · Pull Request #119564 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We once had an issue where switching frames will clear the local variable changes in pdb. PEP 667 fixed it so I closed the original PR to fix the issue. However, we should keep the regression test. Skip news as there's no user observable behavior change.

  • Issue: Switching frame will erase the local variable changes in pdb #102864

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gaogaotiantian
Add switching frame test for pdb
f8e0bd1
@gaogaotiantian gaogaotiantian added the skip news label May 25, 2024
@gaogaotiantian
gaogaotiantian requested a review from iritkatriel May 25, 2024 20:15
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels May 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2024
Switching frame will erase the local variable changes in pdb #102864
Closed
iritkatriel
iritkatriel reviewed May 26, 2024
View reviewed changes
Comment thread Lib/test/test_pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian
Add local variable check after up
69ac134
iritkatriel
iritkatriel approved these changes May 26, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 26, 2024
@iritkatriel
iritkatriel enabled auto-merge (squash) May 26, 2024 16:56
@iritkatriel
iritkatriel merged commit 5d04cc5 into python:main May 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 26, 2024
@gaogaotiantian
gaogaotiantian deleted the pdb-add-locals-test branch May 26, 2024 17:21
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@gaogaotiantian @estyxx
pythongh-102864: Add switching frame test for pdb (python#119564)
a85ce6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gaogaotiantian @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.