GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119562: Remove unused private string constants from `ast.py` by AlexWaygood · Pull Request #119576 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Leftover cruft that should have been deleted in 008bc04, but which I missed

  • Issue: Remove AST nodes deprecated since Python 3.8, with warnings since Python 3.12 #119562

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AlexWaygood
Remove unused private string constants from ast.py
b80ff68
@AlexWaygood
AlexWaygood requested a review from isidentical as a code owner May 26, 2024 12:44
@AlexWaygood AlexWaygood added the skip news label May 26, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 26, 2024
@AlexWaygood AlexWaygood changed the title Remove unused private string constants from ast.py gh-119562: Remove unused private string constants from ast.py May 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 26, 2024
Remove AST nodes deprecated since Python 3.8, with warnings since Python 3.12 #119562
Closed
@AlexWaygood
AlexWaygood enabled auto-merge (squash) May 26, 2024 12:45
@AlexWaygood
AlexWaygood merged commit 0220663 into python:main May 26, 2024
@AlexWaygood
AlexWaygood deleted the unused-strs branch May 26, 2024 13:31
@bedevere-app bedevere-app Bot removed the awaiting core review label May 26, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@AlexWaygood @estyxx
pythongh-119562: Remove unused private string constants from ast.py (…
a81264f
…python#119576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.