GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: Only install sphinx-autobuild for `make htmllive` by hugovk · Pull Request #119607 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 27, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Doctest is failing on the CI because sphinx-autobuild depends on watchfiles, which is Rust and had a new release 2h ago, and fails with a Python 3.14 build:

error: the configured Python interpreter version (3.14) is newer than PyO3's maximum supported version (3.12)
= help: please check if an updated version of PyO3 is available. Current version: 0.21.2
= help: set PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 to suppress this check and build anyway using the stable ABI

https://github.com/python/cpython/actions/runs/9256019877/job/25462093382?pr=119541#step:7:161

we don't need sphinx-autobuild on the CI, let's only install it when doing make htmllive.

📚 Documentation preview 📚: https://cpython-previews--119607.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Only install sphinx-autobuild for 'make htmllive'
06c81ce
@bedevere-app bedevere-app Bot added the awaiting core review label May 27, 2024
@hugovk hugovk added skip issue skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 27, 2024
@hugovk
Ensure a venv before instaling sphinx-autobuild
728b15f
This was referenced May 27, 2024
Docs: Move inline JavaScript to own file to reduce duplication #119541
Merged
Infra: Only install sphinx-autobuild for make htmllive python/peps#3796
Merged
vstinner
vstinner approved these changes May 27, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 27, 2024
@vstinner vstinner mentioned this pull request May 27, 2024
gh-119609: Add PyUnicode_Export() and PyUnicode_Import() functions #119610
Closed
@hugovk
hugovk merged commit 88e3fee into python:main May 27, 2024
@hugovk
hugovk deleted the sphinx-autobuild-only-for-htmllive branch May 27, 2024 17:29
@miss-islington-app

miss-islington-app Bot commented May 27, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
@hugovk @miss-islington
Docs: Only install sphinx-autobuild for make htmllive (pythonGH-119607
4a2156d 
)

(cherry picked from commit 88e3fee)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented May 27, 2024

Copy link
Copy Markdown

GH-119621 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
@hugovk @miss-islington
Docs: Only install sphinx-autobuild for make htmllive (pythonGH-119607
ffdd1b8 
)

(cherry picked from commit 88e3fee)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 27, 2024
@bedevere-app

bedevere-app Bot commented May 27, 2024

Copy link
Copy Markdown

GH-119622 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 27, 2024
hugovk added a commit that referenced this pull request May 27, 2024
@miss-islington @hugovk
[3.12] Docs: Only install sphinx-autobuild for make htmllive (GH-11…
e658d87 
…9607) (#119622)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request May 27, 2024
@miss-islington @hugovk
[3.13] Docs: Only install sphinx-autobuild for make htmllive (GH-11…
ba71835 
…9607) (#119621)

Co-authored-by: Hugo van Kemenade <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@hugovk @estyxx
Docs: Only install sphinx-autobuild for make htmllive (python#119607)
e662f55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.