GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117398: Revert gh-119636, Add multiphase support to _datetime by ericsnowcurrently · Pull Request #119639 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit d58ebf0.

That commit broke many buildbots, so we'll need to regroup.

  • Issue: Isolate the _datetime extension module #117398

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Revert "[3.13] pythongh-117398: Add multiphase support to _datetime (p…
e96963a 
…ythongh-119373) (pythongh-119636)"

This reverts commit d58ebf0.
@ericsnowcurrently
ericsnowcurrently requested review from abalkin and pganssle as code owners May 28, 2024 00:31
@bedevere-app bedevere-app Bot added the awaiting core review label May 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 28, 2024
Isolate the _datetime extension module #117398
Closed
@ericsnowcurrently ericsnowcurrently added the skip news label May 28, 2024
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) May 28, 2024 00:31
@ericsnowcurrently
ericsnowcurrently merged commit 9216a53 into python:3.13 May 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 28, 2024
@ericsnowcurrently
ericsnowcurrently deleted the revert-datetime-multiphase branch May 28, 2024 00:53
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
@ericsnowcurrently
Revert "[3.13] pythongh-117398: Revert pythongh-119636, Add multiphas…
c5f7264 
…e support to _datetime (python#119639)"

This reverts commit 9216a53.
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 28, 2024
[3.13] gh-117398: Add multiphase support to _datetime #119694
Merged
ericsnowcurrently added a commit that referenced this pull request May 29, 2024
@ericsnowcurrently
[3.13] gh-117398: Add multiphase support to _datetime (gh-119694)
af57832 
This is an unrevert of d58ebf0 (gh-119636), which was reverted by 9216a53 (gh-119639) due to problems which have been resolved.

This is minimal support for multiphase init. Subinterpreters are not supported yet. That will be addressed in a later change.

(cherry picked from commit 3e8b609)

Co-authored-by: Erlend E. Aasland [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.