GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97850: remove ``find_loader`` and ``get_loader`` from ``pkgutil`` by picnixz · Pull Request #119656 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented May 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See:

  • Deprecate portions or all of pkgutil module. #64138
  • Meta issue for cleaning up import system cruft #97850

📚 Documentation preview 📚: https://cpython-previews--119656.org.readthedocs.build/

  • Issue: Meta issue for cleaning up import system cruft #97850

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 4 commits May 28, 2024 14:03
@picnixz
deprecate pkgutil.get_loader and pkgutil.find_loader
46b8591
@picnixz
remove deprecated entries
0b0a9fd
@picnixz
add removal notification
c45e3b3
@picnixz
blurb
f59f149
@picnixz
picnixz requested a review from ericsnowcurrently as a code owner May 28, 2024 12:45
@bedevere-app bedevere-app Bot added the awaiting review label May 28, 2024
@picnixz picnixz changed the title Remove find_loader and get_loader from pkgutil gh-#97850: remove find_loader and get_loader from pkgutil May 28, 2024
@picnixz picnixz changed the title gh-#97850: remove find_loader and get_loader from pkgutil gh-97850: remove find_loader and get_loader from pkgutil May 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 28, 2024
Meta issue for cleaning up import system cruft #97850
Open
25 of 31 tasks
@picnixz picnixz changed the title gh-97850: remove find_loader and get_loader from pkgutil [3.14] gh-97850: remove find_loader and get_loader from pkgutil May 28, 2024
@picnixz

picnixz commented May 28, 2024

Copy link
Copy Markdown
Member Author

Quick question but how do you manage the whatsnews sections when a feature is being removed? I cannot really change it to :func:`!pkgutil.find_loader` since these are available in previous versions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Merge branch 'main' into remove-deprecated-pkgutil
fb6b637
@picnixz picnixz changed the title [3.14] gh-97850: remove find_loader and get_loader from pkgutil gh-97850: remove find_loader and get_loader from pkgutil May 28, 2024
sobolevn
sobolevn requested changes May 29, 2024
View reviewed changes

@sobolevn sobolevn left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update

:func:`pkgutil.find_loader`
:func:`pkgutil.get_loader`

to be

:func:`!pkgutil.find_loader`
:func:`!pkgutil.get_loader`

Since all python versions have their own versions of 3.13.rst / 3.12.rst / etc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels May 29, 2024
@bedevere-app

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented May 29, 2024

Copy link
Copy Markdown
Member Author

Yes, that's what I was actually asking. Should I just suppress every possible links in the others 3.x.rst files even though they exist? (if so, I can do it but I wanted to be sure that all references should be suppressed even for old versions for which the reference would exist).
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
remove references to removed entries
a99308e
@sobolevn

sobolevn commented May 29, 2024

Copy link
Copy Markdown
Member

Again, older versions won't be affected, because they live in their own branches. And we won't backport this change.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Merge branch 'main' into remove-deprecated-pkgutil
d72561f
@picnixz

picnixz commented May 29, 2024

Copy link
Copy Markdown
Member Author

Oh yes, it was dumb of me. I incorrectly assumed that the 3.12 page was for the corresponding branch (seems I'm still not entirely awake). Anyway, I have made the requested changes; please review again.
sobolevn reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels May 29, 2024
@bedevere-app

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@sobolevn: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from sobolevn May 29, 2024 08:17
sobolevn
sobolevn reviewed May 29, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I somehow did not send this comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_doctest/test_doctest.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 2 commits May 29, 2024 10:37
@picnixz
remove un-necessary test
be4ef58
@picnixz
Merge branch 'main' into remove-deprecated-pkgutil
aae9c2c
@sobolevn
sobolevn requested a review from brettcannon May 29, 2024 14:27
@sobolevn sobolevn mentioned this pull request Jun 16, 2024
Remove pkgutil.get_loader and pkgutil.findloader #120581
Closed
hugovk
hugovk reviewed Jun 23, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz @hugovk
Update Doc/whatsnew/3.13.rst
4b0e5d0 
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk

hugovk commented Aug 2, 2024

Copy link
Copy Markdown
Member

This has a conflict after the #122085 re-org.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Aug 2, 2024

Copy link
Copy Markdown
Member Author

Oh, I forgot about this one :') I'll fix the conflicts err... I don't know when (I'm a bit busy writing something currently and don't know if I'll have tomorrow)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Aug 2, 2024

Copy link
Copy Markdown
Member

Thanks, absolutely no rush with this :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 3 commits August 3, 2024 09:55
@picnixz
Merge remote-tracking branch 'upstream/main' into remove-deprecated-p…
8b47c67 
…kgutil
@picnixz
Merge branch 'remove-deprecated-pkgutil' of github.com:picnixz/cpytho…
3dbd4c2 
…n into remove-deprecated-pkgutil
@picnixz
update pending removals
5b67897
@Wulian233

Wulian233 commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

#123036
Need change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz and others added 2 commits September 6, 2024 15:42
@picnixz
Merge branch 'main' into remove-deprecated-pkgutil
fb25ff1
@brettcannon
Merge branch 'main' into remove-deprecated-pkgutil
49b6e99
@brettcannon

brettcannon commented Sep 16, 2024

Copy link
Copy Markdown
Member

@picnixz are you waiting on anything for this? You haven't triggered a request for a re-review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Sep 17, 2024

Copy link
Copy Markdown
Member Author

Oh I forgot about it. This one is a low-priority task (which is why I didn't re-request a review) and we were waiting for more experts feedback (such as yours I think?) so we can address this issue when people have the time!

(I'll be barely present for the rest of the week)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Oct 15, 2024

Copy link
Copy Markdown
Member

Where are we up to here?

Our friends at Fedora, who do a huge amount of valuable early testing and fixing of Python packages, are asking about pending deprecations for 3.14:

https://discuss.python.org/t/if-you-plan-to-remove-deprecated-apis-from-python-3-14-please-do-it-now/67955
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Oct 15, 2024

Copy link
Copy Markdown
Member Author

I always forget about this PR :D We actually waited for an expert on pkgutil to confirm that the removal is ok. Apart from that, I don't think I wanted to do more. I'll ask a round of re-review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz requested review from hugovk, sobolevn and warsaw October 15, 2024 13:12
hugovk
hugovk approved these changes Oct 15, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Oct 15, 2024
@hugovk
Merge branch 'main' into remove-deprecated-pkgutil
08c4c07
@brettcannon

brettcannon commented Oct 31, 2024

Copy link
Copy Markdown
Member

We actually waited for an expert on pkgutil to confirm that the removal is ok

There is no pkgutil expert, hence the deprecation (that and it not plugging into importlib cleanly). 😉
picnixz reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Nov 1, 2024

Copy link
Copy Markdown
Member

Let's merge!
picnixz and brettcannon reacted with hooray emoji picnixz reacted with heart emoji
All reactions
  • 🎉 2 reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 464a7a9 into python:main Nov 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 1, 2024
@picnixz
picnixz deleted the remove-deprecated-pkgutil branch November 1, 2024 16:39
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@picnixz @hugovk @brettcannon
pythongh-97850: remove find_loader and get_loader from ``pkgu…
21d2e70 
…til`` (python#119656)

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Brett Cannon <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@picnixz @hugovk
@brettcannon @ebonnal
pythongh-97850: remove find_loader and get_loader from ``pkgu…
eaf9ef4 
…til`` (python#119656)

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Brett Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon
@warsaw warsaw Awaiting requested review from warsaw
@sobolevn sobolevn Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@picnixz @sobolevn @warsaw @hugovk @Wulian233 @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.