GeezerVison is showing github.com — gh-119664: Remove deprecated `co_lnotab` by picnixz · Pull Request #119665 · python/cpython
Conversation
picnixz
commented
May 28, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This removes the deprecated code.co_lnotab attribute.
I am opening a (perhaps incomplete) PR because there are some things I am unusure of, such as:
- is it correct to entirely remove the block in clinic.test.c?
- there are some places where
lnotab is referred so I changed them; should it be addressed separately?
- should we keep the
PyCode_Optimize function?
I know that the doc and the news are not yet updated because I am waiting for feedback.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hugovk
changed the title
[3.14] gh-119664: remove deprecated co_lnotab
gh-119664: Remove deprecated co_lnotab
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs more discussion. See my comment on the issue.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sure! I'll mark the PR as a draft to avoid possible noise for now.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Since it was decided not to do the removal now, I'm closing the PR.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.