GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119664: use conditional removal notice for ``codeobject.co_lnotab`` by picnixz · Pull Request #120263 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jun 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an alternative to #119665 where the removal notice is written in a conditional form.

  • For 3.10: replaced the explicit 3.12 by "future version"
  • For 3.11: nothing was mentioned.
  • For 3.12: used the original 3.13 formulation for the "Deprecated" section. Moved the item under the "Pending removal in 3.14" into the "Pending removal" section. Used the same formulation as in 3.13 as well. Replace the explicit mention of 3.14 by "future version".
  • For 3.13: merged the verbose deprecation notice in the "Deprecated" section with the deprecation notice in the "Pending removal" section. That way, we know that 3.13 is only reminding us that something will be removed in the future, but this is not something that was deprecated in 3.13. There is no need for a "future version" or a "3.14" mention since it is under the "Pending removal in a future version" section.

cc @iritkatriel

  • Issue: Remove deprecated code.co_lnotab #119664

📚 Documentation preview 📚: https://cpython-previews--120263.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@picnixz
use conditional removal notice for codeobject.co_lnotab
cbd0bb7
@bedevere-app bedevere-app Bot mentioned this pull request Jun 8, 2024
Remove deprecated code.co_lnotab #119664
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jun 8, 2024
@picnixz picnixz added the skip news label Aug 17, 2024
@picnixz

picnixz commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

I'm closing this one. I don't think it's worth changing the wording.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz picnixz closed this Aug 27, 2024
@picnixz
picnixz deleted the harmonize-co-lnotab-docs branch August 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.