GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119676: remove several pseudo instructions which are use only in codegen by iritkatriel · Pull Request #119677 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented May 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #119676.

  • Issue: LOAD_SUPER_METHOD etc don't need to be pseudo instructions #119676

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iritkatriel
pythongh-119676: remove several pseudo instructions which are use onl…
370779d
…y in codegen
@iritkatriel
iritkatriel requested a review from markshannon as a code owner May 28, 2024 17:51
@bedevere-app bedevere-app Bot added the awaiting core review label May 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 28, 2024
LOAD_SUPER_METHOD etc don't need to be pseudo instructions #119676
Closed
@carljm carljm added the skip news label May 28, 2024
carljm
carljm approved these changes May 28, 2024
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Not sure why I didn't think of this approach (local integer defines outside the opcodes range) initially.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 28, 2024
@iritkatriel
iritkatriel enabled auto-merge (squash) May 28, 2024 18:00
@iritkatriel
EXIT_INIT_CHECK is not a pseudo-op (it's a normal inst)
6223001
@iritkatriel
iritkatriel merged commit ae9140f into python:main May 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-119676: remove several pseudo instructions which are use onl…
bd4ba28
…y in codegen (python#119677)
@AA-Turner AA-Turner mentioned this pull request Sep 28, 2025
GH-123299: Copyedit 3.14 What's New: CPython bytecode changes #139402
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LOAD_SUPER_METHOD etc don't need to be pseudo instructions

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.