GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` (GH-119573) by miss-islington · Pull Request #119750 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

For silly reasons, pathlib's generic implementation of walk() currently
resides in glob._Globber. This commit moves it into
pathlib._abc.PathBase.walk() where it really belongs, and makes
pathlib.Path.walk() call os.walk().
(cherry picked from commit 7ff61f5)

Co-authored-by: Barney Gale [email protected]

  • Issue: Improve performance of os.walk() #119169

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@barneygale @miss-islington
pythonGH-119169: Implement pathlib.Path.walk() using os.walk() (p…
3668c1a
…ythonGH-119573)

For silly reasons, pathlib's generic implementation of `walk()` currently
resides in `glob._Globber`. This commit moves it into
`pathlib._abc.PathBase.walk()` where it really belongs, and makes
`pathlib.Path.walk()` call `os.walk()`.
(cherry picked from commit 7ff61f5)

Co-authored-by: Barney Gale <[email protected]>
@miss-islington
miss-islington requested a review from barneygale as a code owner May 29, 2024 20:51
@bedevere-app bedevere-app Bot added the awaiting review label May 29, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 29, 2024
Improve performance of os.walk() #119169
Open
@bedevere-app bedevere-app Bot added the skip news label May 29, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 29, 2024
GH-119169: Implement pathlib.Path.walk() using os.walk() #119573
Merged
@barneygale
barneygale enabled auto-merge (squash) May 29, 2024 20:51
@barneygale
barneygale merged commit a7aa7c4 into python:3.13 May 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 29, 2024
@miss-islington
miss-islington deleted the backport-7ff61f5-3.13 branch January 2, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.