GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` by barneygale · Pull Request #119573 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented May 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

For silly reasons, pathlib's generic implementation of walk() currently resides in glob._Globber. This commit moves it into pathlib._abc.PathBase.walk() where it really belongs, and makes pathlib.Path.walk() call though to os.walk() rather than using the generic impl.

Symlink handling is a little different between the two walk() implementations when followlinks=False. In pathlib it means never following symlinks, not even for distinguishing between files and directories. In os it means never walking into symlinks, including any symlinks created by the user between iterations. We smooth over these differences with a private sentinel - os._walk_symlinks_as_files - that enables the pathlib behaviour.

No change of behaviour.

  • Issue: Improve performance of os.walk() #119169

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-119169: Implement pathlib.Path.walk() using os.walk()
1f7d5ad 
For silly reasons, pathlib's generic implementation of `walk()` currently
resides in `glob._Globber`. This commit moves it into
`pathlib._abc.PathBase.walk()` where it really belongs, and makes
`pathlib.Path.walk()` call though to `os.walk()`.

Symlink handling is a little different between the two `walk()`
implementations when `followlinks=False`. In `pathlib` it means never
following symlinks, not even for distinguishing between files and
directories. In `os` it means never *walking* into symlinks, including any
symlinks created by the user between iterations. We smooth over these
differences with a private sentinel - `os._walk_symlinks_as_files` - that
enables the pathlib behaviour.
@barneygale barneygale added skip news topic-pathlib labels May 26, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 26, 2024
Improve performance of os.walk() #119169
Open
@barneygale
Merge branch 'main' into os-walk-unify
33ee9f7
@barneygale

barneygale commented May 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'm intensely embarrassed by my decision to add a _Globber.walk() method to glob.py despite it having little to do with globbing, and so I'm going to merge this PR before anyone else notices my poor life choices.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale added the needs backport to 3.13 only security fixes label May 29, 2024
@barneygale
barneygale enabled auto-merge (squash) May 29, 2024 20:37
@barneygale
barneygale merged commit 7ff61f5 into python:main May 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 29, 2024
@miss-islington-app

miss-islington-app Bot commented May 29, 2024

Copy link
Copy Markdown

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2024
@barneygale @miss-islington
pythonGH-119169: Implement pathlib.Path.walk() using os.walk() (p…
3668c1a 
…ythonGH-119573)

For silly reasons, pathlib's generic implementation of `walk()` currently
resides in `glob._Globber`. This commit moves it into
`pathlib._abc.PathBase.walk()` where it really belongs, and makes
`pathlib.Path.walk()` call `os.walk()`.
(cherry picked from commit 7ff61f5)

Co-authored-by: Barney Gale <[email protected]>
@bedevere-app

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

GH-119750 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 29, 2024
barneygale added a commit that referenced this pull request May 29, 2024
@miss-islington @barneygale
[3.13] GH-119169: Implement pathlib.Path.walk() using os.walk() (G…
a7aa7c4 
…H-119573) (#119750)

GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` (GH-119573)

For silly reasons, pathlib's generic implementation of `walk()` currently
resides in `glob._Globber`. This commit moves it into
`pathlib._abc.PathBase.walk()` where it really belongs, and makes
`pathlib.Path.walk()` call `os.walk()`.
(cherry picked from commit 7ff61f5)

Co-authored-by: Barney Gale <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@barneygale @estyxx
pythonGH-119169: Implement pathlib.Path.walk() using os.walk() (p…
b64cd9f 
…ython#119573)

For silly reasons, pathlib's generic implementation of `walk()` currently
resides in `glob._Globber`. This commit moves it into
`pathlib._abc.PathBase.walk()` where it really belongs, and makes
`pathlib.Path.walk()` call `os.walk()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.