GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119775: Remove ability to create immutable types with mutable bases by sobolevn · Pull Request #119776 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 30, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove deprecated feature to create immutable types with mutable bases #119775

📚 Documentation preview 📚: https://cpython-previews--119776.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
sobolevn requested review from encukou and vstinner May 30, 2024 09:52
@sobolevn
sobolevn requested a review from markshannon as a code owner May 30, 2024 09:52
@bedevere-app bedevere-app Bot added the awaiting core review label May 30, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 30, 2024
Remove deprecated feature to create immutable types with mutable bases #119775
Closed
@sobolevn
pythongh-119775: Remove ability to create immutable types with mutabl…
121bb1b 
…e bases
@sobolevn
sobolevn force-pushed the issue-119775 branch from cae0a73 to 121bb1b Compare May 30, 2024 09:53
carljm
carljm approved these changes May 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 30, 2024
vstinner
vstinner reviewed May 31, 2024
View reviewed changes
Comment thread Lib/test/test_capi/test_misc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added 2 commits June 1, 2024 08:41
@sobolevn
Address review
d03ae98
@sobolevn
Remove method
93c06df
vstinner
vstinner approved these changes Jun 1, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland
erlend-aasland approved these changes Jun 1, 2024
View reviewed changes
@sobolevn
Merge branch 'main' into issue-119775
7dd8471
@sobolevn
sobolevn enabled auto-merge (squash) June 2, 2024 07:03
@sobolevn

sobolevn commented Jun 2, 2024

Copy link
Copy Markdown
Member Author

Thanks everyone! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn merged commit 4aed319 into python:main Jun 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 2, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@sobolevn @barneygale
pythongh-119775: Remove ability to create immutable types with mutabl…
d4aba40 
…e bases (python#119776)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-119775: Remove ability to create immutable types with mutabl…
faa9224 
…e bases (python#119776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@vstinner vstinner vstinner approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@encukou encukou Awaiting requested review from encukou
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @carljm @vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.